<div dir="ltr"><div class="gmail_default" style><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 7, 2013 at 8:19 PM, Dmitri Gribenko <span dir="ltr"><<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">On Mon, Jan 7, 2013 at 9:09 PM, Alexander Kornienko <<a href="mailto:alexfh@google.com">alexfh@google.com</a>> wrote:<br>

> Author: alexfh<br>
> Date: Mon Jan  7 13:09:15 2013<br>
> New Revision: 171768<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=171768&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=171768&view=rev</a><br>
> Log:<br>
> Fixed a number of -Wcovered-switch-default diagnostics in tools/clang/include/clang/AST/AttrDump.inc<br>
><br>
> Modified:<br>
>     cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp<br>
><br>
> Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp?rev=171768&r1=171767&r2=171768&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp?rev=171768&r1=171767&r2=171768&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp (original)<br>
> +++ cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp Mon Jan  7 13:09:15 2013<br>
> @@ -549,11 +549,6 @@<br>
>      }<br>
>      void writeDump(raw_ostream &OS) const {<br>
>        OS << "    switch(SA->get" << getUpperName() << "()) {\n";<br>
> -      OS << "    default:\n";<br>
> -      OS << "      llvm_unreachable(\"Unknown " << getAttrName() << "Attr::"<br>
> -         << type << "!\");\n";<br>
> -      OS << "      break;\n";<br>
> -<br>
>        for (std::vector<StringRef>::const_iterator I = uniques.begin(),<br>
>             E = uniques.end(); I != E; ++I) {<br>
>          OS << "    case " << getAttrName() << "Attr::" << *I << ":\n";<br>
<br>
</div></div>"break" can be replaced "return" in the switch, then we can put the<br>
llvm_unreachable() after the switch().<br></blockquote><div><br></div><div style>There's more code to execute after these switches, so we can't just return here. Take a look at the generated file: tools/clang/include/clang/AST/AttrDump.inc</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><font color="#888888"><br>
Dmitri<br>
<br>
--<br>
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com">gribozavr@gmail.com</a>>*/<br>
</font></span></blockquote></div><br>
</div></div>