<div dir="ltr">Hi,<div><br></div><div>Could you fix the test for Darwin (or split it in two)? It seems some functionalities are not supported:</div><div><br></div><div><div>/Users/filipe/work/<a href="http://llvm.org/clang-only/tools/clang/test/Misc/ast-dump-attr.cpp:82:31">llvm.org/clang-only/tools/clang/test/Misc/ast-dump-attr.cpp:82:31</a>: error: only weak aliases are supported on darwin</div>
<div>int TestString __attribute__((alias("alias1")));</div><div>                              ^</div><div>1 error generated.</div><div>/Users/filipe/work/<a href="http://llvm.org/clang-only/tools/clang/test/Misc/ast-dump-attr.cpp:84:18">llvm.org/clang-only/tools/clang/test/Misc/ast-dump-attr.cpp:84:18</a>: error: expected string not found in input</div>
<div>// CHECK-NEXT:   AliasAttr{{.*}} "alias1"</div><div>                 ^</div><div><stdin>:84:129: note: scanning from here</div></div><div><br></div><div><br></div><div style>Thanks,</div><div style><br>
</div><div style>  Filipe</div></div><div class="gmail_extra"><br clear="all"><div>  F<br></div>
<br><br><div class="gmail_quote">On Mon, Jan 7, 2013 at 11:10 AM, Alexander Kornienko <span dir="ltr"><<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_default">Should be fixed in r171768.</div><div class="gmail_default"><br></div><div class="gmail_default">Thank you for noticing this!</div><div class="gmail_extra"><br><br>
<div class="gmail_quote">On Mon, Jan 7, 2013 at 7:08 PM, Dmitri Gribenko <span dir="ltr"><<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">
<div>On Mon, Jan 7, 2013 at 7:53 PM, Alexander Kornienko <<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>> wrote:<br>
> Author: alexfh<br>
> Date: Mon Jan  7 11:53:08 2013<br>
> New Revision: 171760<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=171760&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=171760&view=rev</a><br>
> Log:<br>
> Implement Attr dumping for -ast-dump.<br>
> <a href="http://llvm-reviews.chandlerc.com/D234" target="_blank">http://llvm-reviews.chandlerc.com/D234</a><br>
><br>
> Patch by Philip Craig!<br>
<br>
</div></div>Hello Alexander,<br>
<br>
It looks like this commit introduced a few warnings like this:<br>
<br>
tools/clang/include/clang/AST/AttrDump.inc:80:5: warning: default<br>
label in switch which covers all enumeration values<br>
[-Wcovered-switch-default]<br>
    default:<br>
    ^<br>
<span><font color="#888888"><br>
Dmitri<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>>*/</font></span></font></span></blockquote></div>
</div></div>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>