<div dir="ltr"><div class="gmail_default" style>On Mon, Jan 7, 2013 at 6:55 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br></div><div class="gmail_extra">
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi,<br>
<br>
the attached patch adds formatting support for the objc formatting<br>
specifiers @public, @protected, @private, and @package. @package is<br>
new in Objective-C 2, so the patch also turns on LangOpts.ObjC2 for<br>
the test.<br>
<br>
The patch formats them like public:, private:, and protected: in c++.<br>
This is definitely correct for google style, and `ack "@public"<br>
test/SemaObjC` suggests that it might be correct for non-google style<br>
too (but that can be tweaked later).<br>
<br>
Ok?<br></blockquote><div><br></div><div><div>+ if (<a href="http://FormatTok.Tok.is">FormatTok.Tok.is</a>(tok::at)) {</div><div>+ nextToken();</div><div>+ switch (FormatTok.Tok.getObjCKeywordID()) {</div><div>+ case tok::objc_public:</div>
<div>+ case tok::objc_protected:</div><div>+ case tok::objc_package:</div><div>+ case tok::objc_private:</div><div>+ return parseAccessSpecifier();</div><div>+ default:</div><div>+ break;</div><div>+ }</div>
<div>+ }</div><div><br></div></div><div style>Please put this into a case tok::at in the switch below.</div><div style><br></div><div style>Apart from that lg</div><div style><br></div><div style>Cheers,</div><div style>
/Manuel</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><font color="#888888"><br>
Nico<br>
</font></span><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div>