<div style="font-family:arial,helvetica,sans-serif;font-size:10pt"><div dir="ltr"><div class="gmail_extra">Hi Richard, I'm afraid this patch regressed crash emission:</div><div class="gmail_extra"><br></div><div class="gmail_extra">

<div class="gmail_extra">nlewycky@ducttape:~$ FORCE_CLANG_DIAGNOSTICS_CRASH=1 llvm/Debug+Asserts/bin/clang -fsyntax-only a.c</div><div class="gmail_extra">clang version 3.3 (trunk 171019)</div><div class="gmail_extra">Target: x86_64-unknown-linux-gnu</div>

<div class="gmail_extra">Thread model: posix</div><div>nlewycky@ducttape:~$ <br></div><div><br></div><div class="gmail_extra" style>If I revert your this patch, it looks right:</div><div class="gmail_extra" style><br></div>

<div class="gmail_extra" style><div class="gmail_extra">nlewycky@ducttape:~$ FORCE_CLANG_DIAGNOSTICS_CRASH=1 llvm/Debug+Asserts/bin/clang -fsyntax-only a.c</div></div><div class="gmail_extra" style><div class="gmail_extra">

clang version 3.3 (trunk 171019)</div><div class="gmail_extra">Target: x86_64-unknown-linux-gnu</div><div class="gmail_extra">Thread model: posix</div><div class="gmail_extra">clang: note: diagnostic msg: PLEASE submit a bug report to <a href="http://llvm.org/bugs/">http://llvm.org/bugs/</a> and include the crash backtrace, preprocessed source, and associated run script.</div>

<div class="gmail_extra">clang: note: diagnostic msg: </div><div class="gmail_extra">********************</div><div class="gmail_extra"><br></div><div class="gmail_extra">PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:</div>

<div class="gmail_extra">Preprocessed source(s) and associated run script(s) are located at:</div><div class="gmail_extra">clang: note: diagnostic msg: /tmp/a-L9z2m9.c</div><div class="gmail_extra">clang: note: diagnostic msg: /tmp/a-L9z2m9.sh</div>

<div class="gmail_extra">clang: note: diagnostic msg: </div><div class="gmail_extra"><br></div><div class="gmail_extra">********************</div></div><div class="gmail_extra" style>nlewycky@ducttape:~$ <br></div><div class="gmail_extra" style>

<br></div><div class="gmail_extra" style>Please fix.</div><div class="gmail_extra" style><br></div><div class="gmail_extra" style>Nick</div><br><div class="gmail_quote">On 19 December 2012 18:22, Richard Smith <span dir="ltr"><<a href="mailto:richard-llvm@metafoo.co.uk" target="_blank">richard-llvm@metafoo.co.uk</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div id=":1jm">note_drv_command_failed_diag_msg</div></blockquote>

</div><br></div></div></div>