<div style="font-family: arial, helvetica, sans-serif; font-size: 10pt"><div dir="ltr">I agree, I did not immediately attempt a fix as I first wanted to ask about the other space (the one between ^ and Block1). Do we want to keep that as well or did you just add that because it was the current state of clang-format?<div>
<br></div><div>Cheers,<br></div><div style>Daniel</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Dec 21, 2012 at 6:09 PM, jahanian <span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Looks like block with initializer adds extra space between '(' and '^' while block without initializer does not.<br>

I think we want to be consistent. Essentially, block formatting should follow that of<br>
function pointer formatting.<br>
<br>
<br>
- Fariborz<br>
<div class="HOEnZb"><div class="h5"><br>
On Dec 21, 2012, at 4:10 AM, Daniel Jasper <<a href="mailto:djasper@google.com">djasper@google.com</a>> wrote:<br>
<br>
> Author: djasper<br>
> Date: Fri Dec 21 06:10:20 2012<br>
> New Revision: 170887<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=170887&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=170887&view=rev</a><br>
> Log:<br>
> Temporary fix of tests to make buildbots happy.<br>
><br>
> Permanent solution coming up after checking back with Fariborz/Douglas.<br>
><br>
> Modified:<br>
>    cfe/trunk/test/Index/comment-c-decls.c<br>
>    cfe/trunk/test/Index/comment-to-html-xml-conversion.cpp<br>
>    cfe/trunk/test/Index/format-comment-cdecls.c<br>
><br>
> Modified: cfe/trunk/test/Index/comment-c-decls.c<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/comment-c-decls.c?rev=170887&r1=170886&r2=170887&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/comment-c-decls.c?rev=170887&r1=170886&r2=170887&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/test/Index/comment-c-decls.c (original)<br>
> +++ cfe/trunk/test/Index/comment-c-decls.c Fri Dec 21 06:10:20 2012<br>
> @@ -101,4 +101,4 @@<br>
>  *\brief block declaration<br>
> */<br>
> int (^Block1) (int i, int j) = ^(int i, int j) { return i + j; };<br>
> -// CHECK: <Declaration>int (^ Block1) (int, int) = ^ (int i, int j) {\n}</Declaration><br>
> +// CHECK: <Declaration>int ( ^ Block1) (int, int) = ^ (int i, int j) {\n}</Declaration><br>
><br>
> Modified: cfe/trunk/test/Index/comment-to-html-xml-conversion.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/comment-to-html-xml-conversion.cpp?rev=170887&r1=170886&r2=170887&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/comment-to-html-xml-conversion.cpp?rev=170887&r1=170886&r2=170887&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/test/Index/comment-to-html-xml-conversion.cpp (original)<br>
> +++ cfe/trunk/test/Index/comment-to-html-xml-conversion.cpp Fri Dec 21 06:10:20 2012<br>
> @@ -670,7 +670,7 @@<br>
> template<typename T, typename U><br>
> class comment_to_xml_conversion_11 { };<br>
><br>
> -// CHECK: comment-to-html-xml-conversion.cpp:[[@LINE-2]]:7: ClassTemplate=comment_to_xml_conversion_11:{{.*}} FullCommentAsXML=[<Class templateKind="template" file="{{[^"]+}}comment-to-html-xml-conversion.cpp" line="[[@LINE-2]]" column="7"><Name>comment_to_xml_conversion_11</Name><USR>c:@CT&gt;2#T#T@comment_to_xml_conversion_11</USR><Declaration>template &lt;typename T = int,\n          typename U = int&gt; class comment_to_xml_conversion_11 {\n}\ntemplate &lt;typename T, typename U&gt; class comment_to_xml_conversion_11 {\n}</Declaration><Abstract><Para> Aaa.</Para></Abstract></Class>]<br>

> +// CHECK: comment-to-html-xml-conversion.cpp:[[@LINE-2]]:7: ClassTemplate=comment_to_xml_conversion_11:{{.*}} FullCommentAsXML=[<Class templateKind="template" file="{{[^"]+}}comment-to-html-xml-conversion.cpp" line="[[@LINE-2]]" column="7"><Name>comment_to_xml_conversion_11</Name><USR>c:@CT&gt;2#T#T@comment_to_xml_conversion_11</USR><Declaration>template &lt;typename T = int, typename U = int&gt;\n    class comment_to_xml_conversion_11 {\n}\ntemplate &lt;typename T, typename U&gt; class comment_to_xml_conversion_11 {\n}</Declaration><Abstract><Para> Aaa.</Para></Abstract></Class>]<br>

><br>
> /// Aaa.<br>
> template<typename T><br>
><br>
> Modified: cfe/trunk/test/Index/format-comment-cdecls.c<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/format-comment-cdecls.c?rev=170887&r1=170886&r2=170887&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/format-comment-cdecls.c?rev=170887&r1=170886&r2=170887&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/test/Index/format-comment-cdecls.c (original)<br>
> +++ cfe/trunk/test/Index/format-comment-cdecls.c Fri Dec 21 06:10:20 2012<br>
> @@ -96,4 +96,4 @@<br>
>  *\brief block declaration<br>
> */<br>
> int (^Block1) (int i, int j) = ^(int i, int j) { return i + j; };<br>
> -// CHECK: <Declaration>int (^ Block1) (int, int) = ^ (int i, int j) {\n}</Declaration><br>
> +// CHECK: <Declaration>int ( ^ Block1) (int, int) = ^ (int i, int j) {\n}</Declaration><br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
</div></div></blockquote></div><br></div></div>