<div style="font-family: arial, helvetica, sans-serif; font-size: 10pt">Thanks, this is useful :-)<br><br><div class="gmail_quote">On Wed, Aug 29, 2012 at 10:17 AM, Fariborz Jahanian <span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: fjahanian<br>
Date: Wed Aug 29 12:17:11 2012<br>
New Revision: 162846<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=162846&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=162846&view=rev</a><br>
Log:<br>
objective-C: make -Widiomatic-parentheses work<br>
when assignment expression in conditional invloves<br>
property reference. // rdar://11066598<br>
<br>
Modified:<br>
cfe/trunk/lib/Sema/SemaExpr.cpp<br>
cfe/trunk/test/SemaObjC/idiomatic-parentheses.m<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=162846&r1=162845&r2=162846&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=162846&r1=162845&r2=162846&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Wed Aug 29 12:17:11 2012<br>
@@ -11191,7 +11191,9 @@<br>
<br>
IsOrAssign = Op->getOperator() == OO_PipeEqual;<br>
Loc = Op->getOperatorLoc();<br>
- } else {<br>
+ } else if (PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(E))<br>
+ return DiagnoseAssignmentAsCondition(POE->getSyntacticForm());<br>
+ else {<br>
// Not an assignment.<br>
return;<br>
}<br>
<br>
Modified: cfe/trunk/test/SemaObjC/idiomatic-parentheses.m<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/idiomatic-parentheses.m?rev=162846&r1=162845&r2=162846&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/idiomatic-parentheses.m?rev=162846&r1=162845&r2=162846&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/SemaObjC/idiomatic-parentheses.m (original)<br>
+++ cfe/trunk/test/SemaObjC/idiomatic-parentheses.m Wed Aug 29 12:17:11 2012<br>
@@ -4,13 +4,18 @@<br>
// <rdar://problem/7382435><br>
<br>
@interface Object<br>
+{<br>
+ unsigned uid;<br>
+}<br>
- (id) init;<br>
- (id) initWithInt: (int) i;<br>
- (void) iterate: (id) coll;<br>
- (id) nextObject;<br>
+@property unsigned uid;<br>
@end<br>
<br>
@implementation Object<br>
+@synthesize uid;<br>
- (id) init {<br>
if (self = [self init]) {<br>
}<br>
@@ -20,6 +25,12 @@<br>
- (id) initWithInt: (int) i {<br>
if (self = [self initWithInt: i]) {<br>
}<br>
+ // rdar://11066598<br>
+ if (self.uid = 100) { // expected-warning {{using the result of an assignment as a condition without parentheses}} \<br>
+ // expected-note {{place parentheses around the assignment to silence this warning}} \<br>
+ // expected-note {{use '==' to turn this assignment into an equality comparison}}<br>
+ // ...<br>
+ }<br>
return self;<br>
}<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>