<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Dec 14, 2012, at 9:14 AM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Dec 14, 2012 at 9:08 AM, Chad Rosier <span dir="ltr"><<a href="mailto:mcrosier@apple.com" target="_blank">mcrosier@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div class="h5">On Dec 13, 2012, at 10:30 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:<br>
</div></div><div><div><div class="h5"><br><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote">On Thu, Dec 13, 2012 at 4:54 PM, Chad Rosier <span dir="ltr"><<a href="mailto:mcrosier@apple.com" target="_blank">mcrosier@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">All,<br>
The attached patch emits a warning in the frontend if the -isysroot flag is given an invalid directory. I've implemented this using llvm::sys:fs::exists(), but please let me know if FileManager::getStatValue() (or another option) is preferred; I'll modify the patch accordingly. I'll also add a test case before pushing the final commit.</blockquote>
<div><br></div><div>Curious: What's the motivation here? I can see it as being potentially more serious than -I /some/invalid/path but we don't warn on that one (at least as far as I know).</div></div></div></blockquote>
<div><br></div></div></div><div>No, we don't.</div><div class="im"><br><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>
Not against it, just curious. :)</div></div></div></blockquote><div><br></div></div><div>It was requested by an internal developer to ease the burden of debugging build failures. :)</div></div></div></blockquote><div><br>
</div><div>Useful, but I'd worry about Joerg's comment. </div></div></div></blockquote><div><br></div><div>I'm going to solicit more internal feedback to see if this is really what we want.</div><br><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote"><div>I can see bootstrapping scenarios such that you wouldn't want it. Possible to only put this warning into -Weverything and not into any other warning level? (TBH I didn't look at the patch so you may have done this…)</div></div></div></blockquote><div><br></div><div>I didn't put it under -Weverything, but that's a good suggestion. Thanks, Eric.</div><br><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote">
<div><br></div><div>-eric </div></div><br></div>
</blockquote></div><br></body></html>