Possibly, but dragonegg uses the old debug builder anyhow.<div><br></div><div>-eric</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Dec 13, 2012 at 3:00 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Thu, Dec 13, 2012 at 2:54 PM, Robinson, Paul<br>
<<a href="mailto:Paul.Robinson@am.sony.com">Paul.Robinson@am.sony.com</a>> wrote:<br>
> Does dragonegg need to be updated as well?<br>
<br>
</div>I don't know, I've not been testing it.<br>
<span class="HOEnZb"><font color="#888888"><br>
- David<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
> --paulr<br>
> ________________________________________<br>
> From: <a href="mailto:cfe-commits-bounces@cs.uiuc.edu">cfe-commits-bounces@cs.uiuc.edu</a> [<a href="mailto:cfe-commits-bounces@cs.uiuc.edu">cfe-commits-bounces@cs.uiuc.edu</a>] on behalf of David Blaikie [<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>]<br>

> Sent: Thursday, December 13, 2012 2:29 PM<br>
> To: <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> Subject: [cfe-commits] r170154 - in /cfe/trunk: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-class.cpp<br>
><br>
> Author: dblaikie<br>
> Date: Thu Dec 13 16:29:06 2012<br>
> New Revision: 170154<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=170154&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=170154&view=rev</a><br>
> Log:<br>
> Debug Info: Emit vtables pointer members as artificial.<br>
><br>
> I wasn't sure where to put the test case for this, but this seemed like as good<br>
> a place as any. I had to reorder the tests here to make them legible while<br>
> still matching the order of metadata output in the IR file (for some reason<br>
> making it virtual changed the ordering).<br>
><br>
> Relevant commit to fix up LLVM to actually respect 'artificial' member<br>
> variables is coming once I write up a test case for it.<br>
><br>
> Modified:<br>
>     cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br>
>     cfe/trunk/test/CodeGenCXX/debug-info-class.cpp<br>
><br>
> Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=170154&r1=170153&r2=170154&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=170154&r1=170153&r2=170154&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original)<br>
> +++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Thu Dec 13 16:29:06 2012<br>
> @@ -1199,7 +1199,7 @@<br>
>    unsigned Size = CGM.getContext().getTypeSize(CGM.getContext().VoidPtrTy);<br>
>    llvm::DIType VPTR<br>
>      = DBuilder.createMemberType(Unit, getVTableName(RD), Unit,<br>
> -                                0, Size, 0, 0, 0,<br>
> +                                0, Size, 0, 0, llvm::DIDescriptor::FlagArtificial,<br>
>                                  getOrCreateVTablePtrType(Unit));<br>
>    EltTys.push_back(VPTR);<br>
>  }<br>
><br>
> Modified: cfe/trunk/test/CodeGenCXX/debug-info-class.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/debug-info-class.cpp?rev=170154&r1=170153&r2=170154&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/debug-info-class.cpp?rev=170154&r1=170153&r2=170154&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/test/CodeGenCXX/debug-info-class.cpp (original)<br>
> +++ cfe/trunk/test/CodeGenCXX/debug-info-class.cpp Thu Dec 13 16:29:06 2012<br>
> @@ -8,6 +8,11 @@<br>
>  union baz;<br>
>  void func(baz *f) { // CHECK: DW_TAG_union_type<br>
>  }<br>
> +class B { // CHECK: DW_TAG_class_type<br>
> +public:<br>
> +  virtual ~B();<br>
> +// CHECK: metadata !"_vptr$B", {{.*}}, i32 64, metadata !{{.*}}} ; [ DW_TAG_member ]<br>
> +};<br>
>  struct A { // CHECK: DW_TAG_structure_type<br>
>    int one;<br>
>    static const int HdrSize = 52; // CHECK: HdrSize<br>
> @@ -16,8 +21,8 @@<br>
>      int x = 1;<br>
>    }<br>
>  };<br>
> -class B { // CHECK: DW_TAG_class_type<br>
> -};<br>
> +<br>
> +<br>
>  int main() {<br>
>    A a;<br>
>    B b;<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>