<html><head><title>Samsung Enterprise Portal mySingle</title>
<meta content="text/html; charset=euc-kr" http-equiv="Content-Type">
<style id="mysingle_style" type="text/css">P {
MARGIN-TOP: 5px; FONT-FAMILY: ±¼¸²Ã¼, arial; MARGIN-BOTTOM: 5px; FONT-SIZE: 9pt
}
TD {
MARGIN-TOP: 5px; FONT-FAMILY: ±¼¸²Ã¼, arial; MARGIN-BOTTOM: 5px; FONT-SIZE: 9pt
}
LI {
MARGIN-TOP: 5px; FONT-FAMILY: ±¼¸²Ã¼, arial; MARGIN-BOTTOM: 5px; FONT-SIZE: 9pt
}
BODY {
LINE-HEIGHT: 1.4; MARGIN: 10px; FONT-FAMILY: ±¼¸²Ã¼, arial; FONT-SIZE: 9pt
}
</style>
<meta name="GENERATOR" content="ActiveSquare">
</head><body>
<p>Hello,</p>
<p> </p>
<p>It works fine when I changed my code like you recommended</p>
<p>I have made the patch again.</p>
<p>Thank you for your advice</p>
<p> </p>
<p>------- <b>Original Message</b> -------</p>
<p><b>Sender</b> : NAKAMURA Takumi<geek4civic@gmail.com></p>
<p><b>Date</b> : 2012-12-11 18:38 (GMT+09:00)</p>
<p><b>Title</b> : Re: [cfe-commits] [Patch] Support multiple path of COMPILER_PATH env on windows platform</p>
<p> </p>Hello, Kim.
<div><br></div>
<div>Thank you to work on Win32.</div>
<div><br></div>
<div>Could you use llvm::sys::PathSeparator there? Please confirm in your environment.</div>
<div><br></div>
<div>FYI, I heard llvm::sys might be deprecated in future. That said, I am not sure when it done.</div>
<div>We may use llvm::sys for now.</div>
<div><br></div>
<div>
<div>--- lib/Driver/Driver.cpp<span style="white-space: pre;"> </span>(revision 169719)</div>
<div>+++ lib/Driver/Driver.cpp<span style="white-space: pre;"> </span>(working copy)</div>
<div>@@ -238,7 +238,11 @@</div>
<div> if (char *env = ::getenv("COMPILER_PATH")) {</div>
<div> StringRef CompilerPath = env;</div>
<div> while (!CompilerPath.empty()) {</div>
<div>- std::pair<StringRef, StringRef> Split = CompilerPath.split(':');</div>
<div>+#ifdef LLVM_ON_WIN32</div>
<div>+ std::pair<StringRef, StringRef> Split = CompilerPath.split(';');</div>
<div>+#else</div>
<div>+ std::pair<StringRef, StringRef> Split = CompilerPath.split(':');</div>
<div>+#endif</div>
<div></div></div>
<div><br></div>
<div>Please be aware of indentation. We prefer to follow the style in existing code.</div>
<div><a href="http://llvm.org/docs/CodingStandards.html#golden-rule">http://llvm.org/docs/CodingStandards.html#golden-rule</a></div>
<div><br></div>
<div>...Takumi</div>
<div><br></div>
<div class="gmail_extra"><br><br>
<div class="gmail_quote">2012/12/11 ±èº¸°ï <span dir="ltr"><<a href="mailto:bogon82.kim@samsung.com" target="_blank">bogon82.kim@samsung.com</a>></span><br>
<blockquote style="margin: 0px 0px 0px 0.8ex; padding-left: 1ex; border-left-color: rgb(204, 204, 204); border-left-width: 1px; border-left-style: solid;" class="gmail_quote">
<div>
<p>Hello, everyone.</p>
<p> </p>
<p>The COMPILER_PATH environment seperator is semicolon on windows as colon on linux</p>
<p> </p>
<p>To support multiple path of COMPILER_PATH env, change the seperator to semicolon for windows platform</p>
<p> </p>
<p>P.S</p>
<p>This is my first contribution. Please let me know if there is any mistakes</p>
<p> </p>
<table style="width: 550px; font-size: 10pt;" border="0" cellSpacing="0" cellPadding="0" width="550">
<tbody>
<tr>
<td height="20" width="261">
<table style="line-height: 150%; font-family: ±¼¸²Ã¼,arial; font-size: 9pt;" border="0" cellSpacing="0" cellPadding="10" width="421" bgColor="#ffffff">
<tbody>
<tr>
<td style="line-height: 150%; font-family: ±¼¸²Ã¼,arial; font-size: 9pt;" height="113" width="159">
<p><img width="156" height="56"></p>
<p align="center"><font color="navy"><b></b></font> </p></td>
<td style="line-height: 70%; font-family: ±¼¸²Ã¼,arial; font-size: 9pt;" height="113" width="222">
<p><font color="navy"><b><span style="font-size: 11pt;">±è º¸ °ï (Bogon Kim)</span></b></font> </p>
<p><span style="font-size: 12pt;"></span> </p>
<p><font color="navy"><b>Platform R&D Group</b></font></p>
<p><font color="navy"><b>Mobile Communication Division</b></font></p>
<p><font color="navy"><b>Samsung Electronics.Co.,LTD</b></font></p>
<p><font face="Arial"><b>TEL 82 - 31 - 301 - 2814</b></font></p>
<p><font face="Arial"><b>Mobile 82 - 11 - 881 - 8458</b></font></p>
<p><font face="Arial"><b>E-mail <a href="mailto:bogon82.kim@samsung.com" target="_blank">bogon82.kim@samsung.com</a></b></font></p>
<p><strong><font color="#800080" face="Arial">With passion and confidence(WPAC)</font></strong></p></td></tr></tbody></table>
<p> </p></td>
<td height="20" width="283">
<p> </p>
<p> </p>
<p> </p>
<p> </p>
<p> </p>
<p> </p>
<p> </p>
<p> </p></td></tr></tbody></table>
<p> </p>
<p> </p>
<table>
<tbody>
<tr>
<td>
<p><img border="0" src="cid:BEI0XT4NZ5JE@namo.co.kr" width="520"></p></td></tr></tbody></table></div><img border="0" width="0" height="0"><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br><br></blockquote></div><br></div>
<p> </p>
<p> </p><!--SP:bogon82.kim-->
<table style="width: 550px; font-size: 10pt;" border="0" cellSpacing="0" borderColor="#000000" borderColorLight="#cccccc" borderColorDark="#808080" cellPadding="0" width="550">
<tbody>
<tr>
<td height="20" width="261">
<table style="line-height: 150%; font-family: ±¼¸²Ã¼,arial; font-size: 9pt;" border="0" cellSpacing="0" cellPadding="10" width="421" bgColor="#ffffff">
<tbody>
<tr>
<td style="line-height: 150%; font-family: ±¼¸²Ã¼,arial; font-size: 9pt;" height="113" width="159">
<p><img src="http://pds.bbs.samsung.net:4010/files/bbs/images/NOTICE/d11bbs_1002/ci-ani2[031007503993].gif" width="156" height="56"></p>
<p align="center"><font color="navy"><b></b></font> </p></td>
<td style="line-height: 70%; font-family: ±¼¸²Ã¼,arial; font-size: 9pt;" height="113" width="222">
<p><font color="navy"><b><span style="font-size: 11pt;">±è º¸ °ï (Bogon Kim)</span></b></font> </p>
<p><span style="font-size: 12pt;"></span> </p>
<p><font color="navy"><b>Platform R&D Group</b></font></p>
<p><font color="navy"><b>Mobile Communication Division</b></font></p>
<p><font color="navy"><b>Samsung Electronics.Co.,LTD</b></font></p>
<p><font face="Arial"><b>TEL 82 - 31 - 301 - 2814</b></font></p>
<p><font face="Arial"><b>Mobile 82 - 11 - 881 - 8458</b></font></p>
<p><font face="Arial"><b>E-mail <a href="mailto:bogon82.kim@samsung.com">bogon82.kim@samsung.com</a></b></font></p>
<p><strong><font color="#800080" face="Arial">With passion and confidence(WPAC)</font></strong></p></td></tr></tbody></table>
<p> </p></td>
<td height="20" width="283">
<p> </p>
<p> </p>
<p> </p>
<p> </p>
<p> </p>
<p> </p>
<p> </p>
<p> </p></td></tr></tbody></table>
<p> </p><!--bogon82.kim:EP-->
<p> </p>
<table id="confidentialsignimg">
<tbody>
<tr>
<td NAMO_LOCK="">
<p><img border="0" src="cid:2LL5XOK0LK7C@namo.co.kr" width="520"></p></td></tr></tbody></table></body></html><img src='http://ext.samsung.net/mailcheck/SeenTimeChecker?do=6699900111cfb4e0bf4fcc2908f0b53c3691d650da8e7bbb398176adecd99b905f887f84397989de4b5562a776ba3bf30029dc535ebebcd3326bbdfb2ea96a2fcf878f9a26ce15a0' border=0 width=0 height=0 style='display:none'>