The patch superficially looks fine. Do you have any performance numbers?<br><br><div class="gmail_quote">On Sat, Nov 24, 2012 at 7:29 AM, Erik Verbruggen <span dir="ltr"><<a href="mailto:erik.verbruggen@me.com" target="_blank">erik.verbruggen@me.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ping?<br>
<br>
Attached is an update patch against rev. #168535.<br>
<br>
<br><br>
<br>
On Nov 5, 2012, at 12:53, Erik Verbruggen <<a href="mailto:erik.verbruggen@me.com">erik.verbruggen@me.com</a>> wrote:<br>
<br>
> Changed getLocStart() and getLocEnd() to be required for Stmts, and make getSourceLocation() optional. The default implementation for getSourceLocation() is build the range by calling getLocStart() and getLocEnd().<br>
><br>
> Patch against rev. #167353.<br>
><br>
> <0001-Fix-for-PR12222.patch>_______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br>