<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>I don't think you're going to get something better...the different kinds of function bodies are just too different to combine them, and skipping a try-statement (the ugliest one) is pretty different from parsing it proper. The one comment I have is that in your catch-parsing, you have a skip-to-lbrace-without-consuming and then immediately consume it, which could be combined into one call, but that's just style. (Oh, and we don't put braces around single-statement ifs.)</div><div><br></div><div>Do you have commit access, or do you need someone to commit for you?</div><div>Jordan</div><div><br></div><br><div><div>On Nov 9, 2012, at 9:29 , Brian Brooks <<a href="mailto:brooks.brian@gmail.com">brooks.brian@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">take two...<br><br><div class="gmail_quote">On Fri, Nov 9, 2012 at 12:26 PM, Brian Brooks <span dir="ltr"><<a href="mailto:brooks.brian@gmail.com" target="_blank">brooks.brian@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<a href="http://llvm.org/bugs/show_bug.cgi?id=9903" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=9903</a><div><br></div><div>After looking at [dcl.fct.def.general] I added a few more test cases for ctor-initializer and tok::equal.</div>
<div><br></div><div>Is there a better way to skip a function-body? I don't think my patch is very elegant.</div><div><br></div><div>Patch attached! Thanks!</div><div><br></div>
</blockquote></div><br>
<span><skip-typedefd-fn-body.patch></span>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></blockquote></div><br></body></html>