On Thu, Oct 18, 2012 at 12:55 AM, Nick Lewycky <span dir="ltr"><<a href="mailto:nicholas@mxc.ca" target="_blank" class="cremed">nicholas@mxc.ca</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: nicholas<br>
Date: Thu Oct 18 02:55:46 2012<br>
New Revision: 166171<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=166171&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=166171&view=rev</a><br>
Log:<br>
Put used="1" on all used declarations in the XML dumper. This allows us to<br>
start seeing the bit so that we can find bugs and write tests for it.<br></blockquote><div><br></div><div>Note, likely the best way to test this bit is to use the AST unit testing facilities we now have, similar to the discussion of the SourceLocation unit tests.</div>
<div><br></div><div>I still think dumping this bit is crazy useful of course... =]</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    cfe/trunk/lib/AST/DumpXML.cpp<br>
<br>
Modified: cfe/trunk/lib/AST/DumpXML.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/DumpXML.cpp?rev=166171&r1=166170&r2=166171&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/DumpXML.cpp?rev=166171&r1=166170&r2=166171&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/AST/DumpXML.cpp (original)<br>
+++ cfe/trunk/lib/AST/DumpXML.cpp Thu Oct 18 02:55:46 2012<br>
@@ -1,4 +1,4 @@<br>
-//===--- DumpXML.cpp - Detailed XML dumping ---------------------*- C++ -*-===//<br>
+//===--- DumpXML.cpp - Detailed XML dumping -------------------------------===//<br>
 //<br>
 //                     The LLVM Compiler Infrastructure<br>
 //<br>
@@ -64,6 +64,8 @@<br>
   static_cast<Impl*>(this)->NAME(static_cast<CLASS*>(D))<br>
<br>
   void dispatch(Decl *D) {<br>
+    if (D->isUsed())<br>
+      static_cast<Impl*>(this)->set("used", "1");<br>
     switch (D->getKind()) {<br>
 #define DECL(DERIVED, BASE) \<br>
       case Decl::DERIVED: \<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" class="cremed">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>