<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>I'll handle that one.</div><div><br></div><div>On Oct 8, 2012, at 6:13 PM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com">chandlerc@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; display: inline !important; float: none; ">On Mon, Oct 8, 2012 at 6:02 PM, Jordan Rose<span class="Apple-converted-space"> </span></span><span dir="ltr" style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><<a href="mailto:jordan_rose@apple.com" target="_blank" class="cremed">jordan_rose@apple.com</a>></span><span style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; display: inline !important; float: none; "><span class="Apple-converted-space"> </span>wrote:</span><br style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div class="gmail_extra" style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; ">This is not your fault, but probably -Wshorten-64-to-32 should get a proper name for the group.<br></blockquote><div><br></div><div>Yea, I just wasn't touching this, too many other things flying for me.</div><div> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; "><div class="HOEnZb"><div class="h5"><br><br>On Oct 8, 2012, at 15:45 , Chandler Carruth <<a href="mailto:chandlerc@gmail.com" class="cremed">chandlerc@gmail.com</a>> wrote:<br><br>> Author: chandlerc<br>> Date: Mon Oct 8 17:45:54 2012<br>> New Revision: 165439<br>><br>> URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=165439&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=165439&view=rev</a><br>> Log:<br>> Sort the subgroups of the diagnostic group for -Wconversion. No<br>> functionality changed.<br>><br>> Modified:<br>> cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>><br>> Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>> URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=165439&r1=165438&r2=165439&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=165439&r1=165438&r2=165439&view=diff</a><br>> ==============================================================================<br>> --- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)<br>> +++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Mon Oct 8 17:45:54 2012<br>> @@ -328,15 +328,15 @@<br>> // - bool-to-pointer conversion warnings are on by default<br>> // - __null-to-integer conversion warnings are on by default<br>> def Conversion : DiagGroup<"conversion",<br>> - [DiagGroup<"shorten-64-to-32">,<br>> + [BoolConversion,<br>> ConstantConversion,<br>> + DiagGroup<"shorten-64-to-32">,<br>> + IntConversion,<br>> LiteralConversion,<br>> - StringConversion,<br>> - SignConversion,<br>> - BoolConversion,<br>> - NullConversion, // NULL->non-pointer<br>> NonLiteralNullConversion, // (1-1)->pointer (etc)<br>> - IntConversion]>,<br>> + NullConversion, // NULL->non-pointer<br>> + SignConversion,<br>> + StringConversion]>,<br>> DiagCategory<"Value Conversion Issue">;<br>><br>> def Unused : DiagGroup<"unused",<br>><br>><br>> _______________________________________________<br>> cfe-commits mailing list<br>><span class="Apple-converted-space"> </span><a href="mailto:cfe-commits@cs.uiuc.edu" class="cremed">cfe-commits@cs.uiuc.edu</a><br>><span class="Apple-converted-space"> </span><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu" class="cremed">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br></div></div></blockquote></div><br></div><span style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; display: inline !important; float: none; "></span><br class="Apple-interchange-newline"></blockquote></div><br></body></html>