On Mon, Oct 8, 2012 at 6:02 PM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank" class="cremed">jordan_rose@apple.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is not your fault, but probably -Wshorten-64-to-32 should get a proper name for the group.<br></blockquote><div><br>
</div><div>Yea, I just wasn't touching this, too many other things flying for me.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<br>
On Oct 8, 2012, at 15:45 , Chandler Carruth <<a href="mailto:chandlerc@gmail.com" class="cremed">chandlerc@gmail.com</a>> wrote:<br>
<br>
> Author: chandlerc<br>
> Date: Mon Oct  8 17:45:54 2012<br>
> New Revision: 165439<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=165439&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=165439&view=rev</a><br>
> Log:<br>
> Sort the subgroups of the diagnostic group for -Wconversion. No<br>
> functionality changed.<br>
><br>
> Modified:<br>
>    cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>
><br>
> Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=165439&r1=165438&r2=165439&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=165439&r1=165438&r2=165439&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)<br>
> +++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Mon Oct  8 17:45:54 2012<br>
> @@ -328,15 +328,15 @@<br>
> //   - bool-to-pointer conversion warnings are on by default<br>
> //   - __null-to-integer conversion warnings are on by default<br>
> def Conversion : DiagGroup<"conversion",<br>
> -                           [DiagGroup<"shorten-64-to-32">,<br>
> +                           [BoolConversion,<br>
>                             ConstantConversion,<br>
> +                            DiagGroup<"shorten-64-to-32">,<br>
> +                            IntConversion,<br>
>                             LiteralConversion,<br>
> -                            StringConversion,<br>
> -                            SignConversion,<br>
> -                            BoolConversion,<br>
> -                            NullConversion, // NULL->non-pointer<br>
>                             NonLiteralNullConversion, // (1-1)->pointer (etc)<br>
> -                            IntConversion]>,<br>
> +                            NullConversion, // NULL->non-pointer<br>
> +                            SignConversion,<br>
> +                            StringConversion]>,<br>
>                  DiagCategory<"Value Conversion Issue">;<br>
><br>
> def Unused : DiagGroup<"unused",<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu" class="cremed">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" class="cremed">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>