<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.apple-tab-span
{mso-style-name:apple-tab-span;}
span.hoenzb
{mso-style-name:hoenzb;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thank you for the review. Committed as r165234 with both fixes.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thanks!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Michael<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> metafoo@gmail.com [mailto:metafoo@gmail.com]
<b>On Behalf Of </b>Richard Smith<br>
<b>Sent:</b> Wednesday, October 03, 2012 10:51 PM<br>
<b>To:</b> Michael Han<br>
<b>Cc:</b> cfe-commits@cs.uiuc.edu<br>
<b>Subject:</b> Re: [Patch] correct scope token location when parsing GNU attributes<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">> --- lib/Sema/SemaDecl.cpp<span class="apple-tab-span"> </span>
(revision 165089)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">> +++ lib/Sema/SemaDecl.cpp<span class="apple-tab-span">
</span>(working copy)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">> @@ -2774,7 +2774,8 @@<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">> TypeSpecType == DeclSpec::TST_enum) {<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">> AttributeList* attrs = DS.getAttributes().getList();<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">> while (attrs) {<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">> - Diag(attrs->getScopeLoc(),<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">> + Diag(attrs->getScopeLoc().isValid() ? <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">> + attrs->getScopeLoc() : attrs->getLoc(),<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">You can just use attrs->getLoc() here; it points to the first token of the attribute. LGTM with that change.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Incidentally, Parser::ParseGNUAttributeArgs's call to addNew isn't passing in the right SourceRange any more: the start should be ScopeLoc if it is valid.<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Tue, Oct 2, 2012 at 10:03 PM, Michael Han <<a href="mailto:Michael.Han@autodesk.com" target="_blank">Michael.Han@autodesk.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">Hi,<br>
<br>
Attached patch correct the source location of scopes when parsing and creating an attribute in GNU syntax: since the GNU syntax attribute does not have scope tokens, we shall use a newly created SourceLocation() instead of reuse the attribute token source location.
As a result, when emitting diagnostics the valid of the locations needs to be checked first before used.<br>
<span style="color:#888888"><br>
<span class="hoenzb">Michael</span></span><o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>