On Thu, Oct 4, 2012 at 3:12 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank" class="cremed">chandlerc@google.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Can we get a test case for this?</blockquote><div><br></div><div>Also, not just for this, but for all of the source location fixes you're making?</div>
<div><br></div><div>We've got *lots* of source location bugs (as you're finding!) and we really need to start testing them in addition to fixing them.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><br></div><div>While previously, our ability to regression test the AST has been limited, I think with the tooling infrastructure we got enough unittest infrastructure to grab the AST node and call methods on it asserting their expected contents.</div>
<div class="HOEnZb"><div class="h5">
<div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Oct 4, 2012 at 2:38 PM, Abramo Bagnara <span dir="ltr"><<a href="mailto:abramo.bagnara@bugseng.com" target="_blank" class="cremed">abramo.bagnara@bugseng.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: abramo<br>
Date: Thu Oct  4 16:38:29 2012<br>
New Revision: 165256<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=165256&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=165256&view=rev</a><br>
Log:<br>
Fixed ParamDecl source range for implicit typed k&r parameters.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Sema/SemaDecl.cpp<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDecl.cpp?rev=165256&r1=165255&r2=165256&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDecl.cpp?rev=165256&r1=165255&r2=165256&view=diff</a><br>


==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaDecl.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaDecl.cpp Thu Oct  4 16:38:29 2012<br>
@@ -7574,6 +7574,9 @@<br>
         unsigned DiagID; // unused<br>
         DS.SetTypeSpecType(DeclSpec::TST_int, FTI.ArgInfo[i].IdentLoc,<br>
                            PrevSpec, DiagID);<br>
+        // Use the identifier location for the type source range.<br>
+        DS.SetRangeStart(FTI.ArgInfo[i].IdentLoc);<br>
+        DS.SetRangeEnd(FTI.ArgInfo[i].IdentLoc);<br>
         Declarator ParamD(DS, Declarator::KNRTypeListContext);<br>
         ParamD.SetIdentifier(FTI.ArgInfo[i].Ident, FTI.ArgInfo[i].IdentLoc);<br>
         FTI.ArgInfo[i].Param = ActOnParamDeclarator(S, ParamD);<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank" class="cremed">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>