FYI, I want to look at this, but am *swamped* this week. =/ I'm sorry my review latency keeps climbing without bound.<div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 20, 2012 at 2:28 PM, Sebastian Pop <span dir="ltr"><<a href="mailto:spop@codeaurora.org" target="_blank">spop@codeaurora.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
With a few small changes, I will be happy with this patch: see the comments<br>
inline.<br>
<div><div class="h5"><br>
Matthew Curtis wrote:<br>
> - Inherit from Linux rather than ToolChain<br>
> - Override AddClangSystemIncludeArgs and AddClangCXXStdlibIncludeArgs<br>
> to properly set include paths.<br>
><br>
> Cheers,<br>
> Matthew Curtis<br>
><br>
> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora<br>
> Forum, hosted by The Linux Foundation<br>
<br>
</div></div>> From 5b03fc402ee4e080231aa389634649f2f5660d70 Mon Sep 17 00:00:00 2001<br>
> From: Matthew Curtis <<a href="mailto:mcurtis@codeaurora.org">mcurtis@codeaurora.org</a>><br>
> Date: Thu, 13 Sep 2012 09:48:43 -0500<br>
> Subject: [PATCH 1/6] Hexagon TC: Update toolchain to add appropriate include<br>
> paths<br>
<div class="im">><br>
> - Inherit from Linux rather than ToolChain<br>
> - Override AddClangSystemIncludeArgs and AddClangCXXStdlibIncludeArgs<br>
> to properly set include paths.<br>
</div>> ---<br>
> lib/Driver/Driver.cpp | 2 +-<br>
> lib/Driver/ToolChains.cpp | 86 ++++++++++++++++++--<br>
> lib/Driver/ToolChains.h | 42 ++++++----<br>
> lib/Driver/Tools.cpp | 1 -<br>
> test/Driver/Inputs/hexagon_tree/gnu/bin/hexagon-as | 1 +<br>
> .../Driver/Inputs/hexagon_tree/gnu/bin/hexagon-gcc | 1 +<br>
> .../hexagon_tree/gnu/hexagon/include/c++/4.4.0/ios | 1 +<br>
> .../hexagon_tree/gnu/hexagon/include/stdio.h | 1 +<br>
> .../lib/gcc/hexagon/4.4.0/include-fixed/limits.h | 1 +<br>
> .../gnu/lib/gcc/hexagon/4.4.0/include/stddef.h | 1 +<br>
> test/Driver/Inputs/hexagon_tree/qc/bin/placeholder | 1 +<br>
> test/Driver/hexagon-toolchain.c | 71 ++++++++++++++++<br>
> 12 files changed, 185 insertions(+), 24 deletions(-)<br>
> create mode 100755 test/Driver/Inputs/hexagon_tree/gnu/bin/hexagon-as<br>
> create mode 100755 test/Driver/Inputs/hexagon_tree/gnu/bin/hexagon-gcc<br>
> create mode 100644 test/Driver/Inputs/hexagon_tree/gnu/hexagon/include/c++/4.4.0/ios<br>
> create mode 100644 test/Driver/Inputs/hexagon_tree/gnu/hexagon/include/stdio.h<br>
> create mode 100644 test/Driver/Inputs/hexagon_tree/gnu/lib/gcc/hexagon/4.4.0/include-fixed/limits.h<br>
> create mode 100644 test/Driver/Inputs/hexagon_tree/gnu/lib/gcc/hexagon/4.4.0/include/stddef.h<br>
> create mode 100644 test/Driver/Inputs/hexagon_tree/qc/bin/placeholder<br>
> create mode 100644 test/Driver/hexagon-toolchain.c<br>
<br>
Thanks for adding these tests.<br>
<br>
><br>
> diff --git a/lib/Driver/Driver.cpp b/lib/Driver/Driver.cpp<br>
> index afdc2a3..a2eb54f 100644<br>
> --- a/lib/Driver/Driver.cpp<br>
> +++ b/lib/Driver/Driver.cpp<br>
> @@ -1790,7 +1790,7 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,<br>
> break;<br>
> case llvm::Triple::Linux:<br>
> if (Target.getArch() == llvm::Triple::hexagon)<br>
> - TC = new toolchains::Hexagon_TC(*this, Target);<br>
> + TC = new toolchains::Hexagon_TC(*this, Target, Args);<br>
> else<br>
> TC = new toolchains::Linux(*this, Target, Args);<br>
> break;<br>
> diff --git a/lib/Driver/ToolChains.cpp b/lib/Driver/ToolChains.cpp<br>
> index 0fd5202..2883e9a 100644<br>
> --- a/lib/Driver/ToolChains.cpp<br>
> +++ b/lib/Driver/ToolChains.cpp<br>
> @@ -1423,11 +1423,46 @@ const char *Generic_GCC::GetForcedPicModel() const {<br>
> }<br>
> /// Hexagon Toolchain<br>
><br>
> -Hexagon_TC::Hexagon_TC(const Driver &D, const llvm::Triple& Triple)<br>
> - : ToolChain(D, Triple) {<br>
> - getProgramPaths().push_back(getDriver().getInstalledDir());<br>
> - if (getDriver().getInstalledDir() != getDriver().Dir.c_str())<br>
> - getProgramPaths().push_back(getDriver().Dir);<br>
> +std::string Hexagon_TC::GetGnuDir(const std::string &InstalledDir) {<br>
> + std::string InstallRelDir;<br>
> + std::string PrefixRelDir;<br>
> +<br>
> + // Locate the rest of the toolchain ...<br>
> + if (strlen(GCC_INSTALL_PREFIX))<br>
> + return std::string(GCC_INSTALL_PREFIX);<br>
> + else if (llvm::sys::fs::exists(InstallRelDir = InstalledDir + "/../../gnu"))<br>
<br>
Please remove all the useless "else"s as you are returning from each case.<br>
<br>
> + return InstallRelDir;<br>
> + else if (llvm::sys::fs::exists(<br>
> + PrefixRelDir = std::string(LLVM_PREFIX) + "/../gnu"))<br>
<br>
The indentation does not look good here.<br>
<br>
> + return PrefixRelDir;<br>
> + else<br>
> + return InstallRelDir;<br>
> +}<br>
> +<br>
> +Hexagon_TC::Hexagon_TC(const Driver &D, const llvm::Triple& Triple,<br>
<br>
s/llvm::Triple& Triple/llvm::Triple &Triple/<br>
<br>
> + const ArgList &Args)<br>
> + : Linux(D, Triple, Args) {<br>
> + const std::string InstalledDir(getDriver().getInstalledDir());<br>
> +<br>
> + // Note: Generic_GCC::Generic_GCC adds InstalledDir and DriverDir<br>
<br>
I think you will have to update this comment.<br>
<br>
> +<br>
> + const std::string GnuDir = Hexagon_TC::GetGnuDir(InstalledDir);<br>
> +<br>
> + const std::string BinDir(GnuDir + "/bin");<br>
> + if (llvm::sys::fs::exists(BinDir))<br>
> + getProgramPaths().push_back(BinDir);<br>
> +<br>
> + // Determine version of GCC Libraries and Headers to use<br>
<br>
s/Libraries/libraries/<br>
s/Headers/headers/<br>
<br>
Add a dot at the end of the sentence.<br>
<br>
> + const std::string HexagonDir(GnuDir + "/lib/gcc/hexagon");<br>
> + llvm::error_code ec;<br>
> + GCCVersion MaxVersion= GCCVersion::Parse("0.0.0");<br>
<br>
space before =<br>
<br>
> + for (llvm::sys::fs::directory_iterator di(HexagonDir, ec), de;<br>
> + !ec && di != de; di = di.increment(ec)) {<br>
> + GCCVersion cv = GCCVersion::Parse(llvm::sys::path::filename(di->path()));<br>
> + if (MaxVersion < cv)<br>
> + MaxVersion = cv;<br>
> + }<br>
> + GCCLibAndIncVersion= MaxVersion;<br>
<br>
space before =<br>
<br>
> }<br>
><br>
> Hexagon_TC::~Hexagon_TC() {<br>
> @@ -1486,7 +1521,46 @@ const char *Hexagon_TC::GetDefaultRelocationModel() const {<br>
><br>
> const char *Hexagon_TC::GetForcedPicModel() const {<br>
> return 0;<br>
> -} // End Hexagon<br>
> +}<br>
> +<br>
> +void Hexagon_TC::AddClangSystemIncludeArgs(const ArgList &DriverArgs,<br>
> + ArgStringList &CC1Args) const {<br>
<br>
indent<br>
<br>
> + const Driver &D = getDriver();<br>
> +<br>
> + if (DriverArgs.hasArg(options::OPT_nostdinc))<br>
> + return;<br>
> + if (DriverArgs.hasArg(options::OPT_nostdlibinc))<br>
> + return;<br>
<br>
I prefer to read the version with || that you have below:<br>
<br>
> + if (DriverArgs.hasArg(options::OPT_nostdlibinc) ||<br>
> + DriverArgs.hasArg(options::OPT_nostdincxx))<br>
> + return;<br>
<br>
<br>
> +<br>
> + llvm::sys::Path InstallDir(D.InstalledDir);<br>
> + std::string Ver(GetGCCLibAndIncVersion());<br>
> + std::string GnuDir = Hexagon_TC::GetGnuDir(D.InstalledDir);<br>
> + std::string HexagonDir(GnuDir +<br>
> + "/lib/gcc/hexagon/" +<br>
> + Ver);<br>
<br>
fill up the 80 columns<br>
<br>
> + addExternCSystemInclude(DriverArgs, CC1Args, HexagonDir + "/include");<br>
> + addExternCSystemInclude(DriverArgs, CC1Args, HexagonDir + "/include-fixed");<br>
> + addExternCSystemInclude(DriverArgs, CC1Args,<br>
> + GnuDir +<br>
> + "/hexagon/include");<br>
<br>
fill up the 80 columns<br>
<br>
> +}<br>
> +<br>
> +void Hexagon_TC::AddClangCXXStdlibIncludeArgs(const ArgList &DriverArgs,<br>
> + ArgStringList &CC1Args) const {<br>
<br>
indent<br>
<br>
> +<br>
> + if (DriverArgs.hasArg(options::OPT_nostdlibinc) ||<br>
> + DriverArgs.hasArg(options::OPT_nostdincxx))<br>
> + return;<br>
> +<br>
> + const Driver &D = getDriver();<br>
> + std::string Ver(GetGCCLibAndIncVersion());<br>
> + llvm::sys::Path IncludeDir(Hexagon_TC::GetGnuDir(D.InstalledDir));<br>
> +<br>
> + IncludeDir.appendComponent("hexagon/include/c++/");<br>
> + IncludeDir.appendComponent(Ver);<br>
> + addSystemInclude(DriverArgs, CC1Args, IncludeDir.str());<br>
> +}<br>
> +// End Hexagon<br>
><br>
><br>
> /// TCEToolChain - A tool chain using the llvm bitcode tools to perform<br>
> diff --git a/lib/Driver/ToolChains.h b/lib/Driver/ToolChains.h<br>
> index 752cdfd..d99e9b9 100644<br>
> --- a/lib/Driver/ToolChains.h<br>
> +++ b/lib/Driver/ToolChains.h<br>
> @@ -144,22 +144,6 @@ protected:<br>
> /// @}<br>
> };<br>
><br>
> -class LLVM_LIBRARY_VISIBILITY Hexagon_TC : public ToolChain {<br>
> -protected:<br>
> - mutable llvm::DenseMap<unsigned, Tool*> Tools;<br>
> -<br>
> -public:<br>
> - Hexagon_TC(const Driver &D, const llvm::Triple& Triple);<br>
> - ~Hexagon_TC();<br>
> -<br>
> - virtual Tool &SelectTool(const Compilation &C, const JobAction &JA,<br>
> - const ActionList &Inputs) const;<br>
> -<br>
> - virtual bool IsUnwindTablesDefault() const;<br>
> - virtual const char *GetDefaultRelocationModel() const;<br>
> - virtual const char *GetForcedPicModel() const;<br>
> -};<br>
> -<br>
> /// Darwin - The base Darwin tool chain.<br>
> class LLVM_LIBRARY_VISIBILITY Darwin : public ToolChain {<br>
> public:<br>
> @@ -529,6 +513,32 @@ private:<br>
> ArgStringList &CC1Args);<br>
> };<br>
><br>
> +class LLVM_LIBRARY_VISIBILITY Hexagon_TC : public Linux {<br>
> +protected:<br>
> + mutable llvm::DenseMap<unsigned, Tool*> Tools;<br>
> +<br>
> + GCCVersion GCCLibAndIncVersion;<br>
> +<br>
> +public:<br>
> + Hexagon_TC(const Driver &D, const llvm::Triple& Triple,<br>
<br>
s/llvm::Triple& Triple/llvm::Triple &Triple/<br>
<br>
> + const ArgList &Args);<br>
> + ~Hexagon_TC();<br>
> +<br>
> + virtual Tool &SelectTool(const Compilation &C, const JobAction &JA,<br>
> + const ActionList &Inputs) const;<br>
> +<br>
> + virtual bool IsUnwindTablesDefault() const;<br>
> + virtual const char *GetDefaultRelocationModel() const;<br>
> + virtual const char *GetForcedPicModel() const;<br>
> + virtual void AddClangSystemIncludeArgs(const ArgList &DriverArgs,<br>
> + ArgStringList &CC1Args) const;<br>
> + virtual void AddClangCXXStdlibIncludeArgs(const ArgList &DriverArgs,<br>
> + ArgStringList &CC1Args) const;<br>
> +<br>
> + StringRef GetGCCLibAndIncVersion() const { return GCCLibAndIncVersion.Text; }<br>
> +<br>
> + static std::string GetGnuDir(const std::string &InstalledDir);<br>
> +};<br>
><br>
> /// TCEToolChain - A tool chain using the llvm bitcode tools to perform<br>
> /// all subcommands. See <a href="http://tce.cs.tut.fi" target="_blank">http://tce.cs.tut.fi</a> for our peculiar target.<br>
> diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp<br>
> index 63182f8..3c4bd95 100644<br>
> --- a/lib/Driver/Tools.cpp<br>
> +++ b/lib/Driver/Tools.cpp<br>
> @@ -1198,7 +1198,6 @@ void Clang::AddHexagonTargetArgs(const ArgList &Args,<br>
> CmdArgs.push_back("-target-cpu");<br>
> CmdArgs.push_back(Args.MakeArgString("hexagon" + getHexagonTargetCPU(Args)));<br>
> CmdArgs.push_back("-fno-signed-char");<br>
> - CmdArgs.push_back("-nobuiltininc");<br>
><br>
> if (Args.hasArg(options::OPT_mqdsp6_compat))<br>
> CmdArgs.push_back("-mqdsp6-compat");<br>
> diff --git a/test/Driver/Inputs/hexagon_tree/gnu/bin/hexagon-as b/test/Driver/Inputs/hexagon_tree/gnu/bin/hexagon-as<br>
> new file mode 100755<br>
> index 0000000..331ef4a<br>
> --- /dev/null<br>
> +++ b/test/Driver/Inputs/hexagon_tree/gnu/bin/hexagon-as<br>
> @@ -0,0 +1 @@<br>
> +# placeholder for testing purposes<br>
> \ No newline at end of file<br>
> diff --git a/test/Driver/Inputs/hexagon_tree/gnu/bin/hexagon-gcc b/test/Driver/Inputs/hexagon_tree/gnu/bin/hexagon-gcc<br>
> new file mode 100755<br>
> index 0000000..331ef4a<br>
> --- /dev/null<br>
> +++ b/test/Driver/Inputs/hexagon_tree/gnu/bin/hexagon-gcc<br>
> @@ -0,0 +1 @@<br>
> +# placeholder for testing purposes<br>
> \ No newline at end of file<br>
> diff --git a/test/Driver/Inputs/hexagon_tree/gnu/hexagon/include/c++/4.4.0/ios b/test/Driver/Inputs/hexagon_tree/gnu/hexagon/include/c++/4.4.0/ios<br>
> new file mode 100644<br>
> index 0000000..777a4ec<br>
> --- /dev/null<br>
> +++ b/test/Driver/Inputs/hexagon_tree/gnu/hexagon/include/c++/4.4.0/ios<br>
> @@ -0,0 +1 @@<br>
> +// placeholder for testing purposes<br>
> diff --git a/test/Driver/Inputs/hexagon_tree/gnu/hexagon/include/stdio.h b/test/Driver/Inputs/hexagon_tree/gnu/hexagon/include/stdio.h<br>
> new file mode 100644<br>
> index 0000000..777a4ec<br>
> --- /dev/null<br>
> +++ b/test/Driver/Inputs/hexagon_tree/gnu/hexagon/include/stdio.h<br>
> @@ -0,0 +1 @@<br>
> +// placeholder for testing purposes<br>
> diff --git a/test/Driver/Inputs/hexagon_tree/gnu/lib/gcc/hexagon/4.4.0/include-fixed/limits.h b/test/Driver/Inputs/hexagon_tree/gnu/lib/gcc/hexagon/4.4.0/include-fixed/limits.h<br>
> new file mode 100644<br>
> index 0000000..777a4ec<br>
> --- /dev/null<br>
> +++ b/test/Driver/Inputs/hexagon_tree/gnu/lib/gcc/hexagon/4.4.0/include-fixed/limits.h<br>
> @@ -0,0 +1 @@<br>
> +// placeholder for testing purposes<br>
> diff --git a/test/Driver/Inputs/hexagon_tree/gnu/lib/gcc/hexagon/4.4.0/include/stddef.h b/test/Driver/Inputs/hexagon_tree/gnu/lib/gcc/hexagon/4.4.0/include/stddef.h<br>
> new file mode 100644<br>
> index 0000000..777a4ec<br>
> --- /dev/null<br>
> +++ b/test/Driver/Inputs/hexagon_tree/gnu/lib/gcc/hexagon/4.4.0/include/stddef.h<br>
> @@ -0,0 +1 @@<br>
> +// placeholder for testing purposes<br>
> diff --git a/test/Driver/Inputs/hexagon_tree/qc/bin/placeholder b/test/Driver/Inputs/hexagon_tree/qc/bin/placeholder<br>
> new file mode 100644<br>
> index 0000000..777a4ec<br>
> --- /dev/null<br>
> +++ b/test/Driver/Inputs/hexagon_tree/qc/bin/placeholder<br>
> @@ -0,0 +1 @@<br>
> +// placeholder for testing purposes<br>
> diff --git a/test/Driver/hexagon-toolchain.c b/test/Driver/hexagon-toolchain.c<br>
> new file mode 100644<br>
> index 0000000..a0ae693<br>
> --- /dev/null<br>
> +++ b/test/Driver/hexagon-toolchain.c<br>
> @@ -0,0 +1,71 @@<br>
> +// REQUIRES: hexagon-registered-target<br>
> +<br>
> +// -----------------------------------------------------------------------------<br>
> +// Test standard include paths<br>
> +// -----------------------------------------------------------------------------<br>
> +<br>
> +// RUN: %clang -### -target hexagon-unknown-linux \<br>
> +// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/qc/bin \<br>
> +// RUN: %s 2>&1 \<br>
> +// RUN: | FileCheck -check-prefix=CHECK001 %s<br>
> +// CHECK001: "-cc1" {{.*}} "-internal-externc-isystem" "[[INSTALL_DIR:.*]]/Inputs/hexagon_tree/qc/bin/../../gnu/lib/gcc/hexagon/4.4.0/include"<br>
> +// CHECK001: "-internal-externc-isystem" "[[INSTALL_DIR]]/Inputs/hexagon_tree/qc/bin/../../gnu/lib/gcc/hexagon/4.4.0/include-fixed"<br>
> +// CHECK001: "-internal-externc-isystem" "[[INSTALL_DIR]]/Inputs/hexagon_tree/qc/bin/../../gnu/hexagon/include"<br>
> +// CHECK001-NEXT: "[[INSTALL_DIR]]/Inputs/hexagon_tree/qc/bin/../../gnu/bin/hexagon-as"<br>
> +<br>
> +// RUN: %clang -ccc-cxx -x c++ -### -target hexagon-unknown-linux \<br>
> +// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/qc/bin \<br>
> +// RUN: %s 2>&1 \<br>
> +// RUN: | FileCheck -check-prefix=CHECK002 %s<br>
> +// CHECK002: "-cc1" {{.*}} "-internal-isystem" "[[INSTALL_DIR:.*]]/Inputs/hexagon_tree/qc/bin/../../gnu/hexagon/include/c++/4.4.0"<br>
> +// CHECK002: "-internal-externc-isystem" "[[INSTALL_DIR]]/Inputs/hexagon_tree/qc/bin/../../gnu/lib/gcc/hexagon/4.4.0/include"<br>
> +// CHECK002: "-internal-externc-isystem" "[[INSTALL_DIR]]/Inputs/hexagon_tree/qc/bin/../../gnu/lib/gcc/hexagon/4.4.0/include-fixed"<br>
> +// CHECK002: "-internal-externc-isystem" "[[INSTALL_DIR]]/Inputs/hexagon_tree/qc/bin/../../gnu/hexagon/include"<br>
> +// CHECK002-NEXT: "[[INSTALL_DIR]]/Inputs/hexagon_tree/qc/bin/../../gnu/bin/hexagon-as"<br>
> +<br>
> +// -----------------------------------------------------------------------------<br>
> +// Test -nostdinc, -nostdlibinc, -nostdinc++<br>
> +// -----------------------------------------------------------------------------<br>
> +<br>
> +// RUN: %clang -### -target hexagon-unknown-linux \<br>
> +// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/qc/bin \<br>
> +// RUN: -nostdinc \<br>
> +// RUN: %s 2>&1 \<br>
> +// RUN: | FileCheck -check-prefix=CHECK003 %s<br>
> +// CHECK003: "-cc1"<br>
> +// CHECK003-NOT: "-internal-externc-isystem" "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/lib/gcc/hexagon/4.4.0/include"<br>
> +// CHECK003-NOT: "-internal-externc-isystem" "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/lib/gcc/hexagon/4.4.0/include-fixed"<br>
> +// CHECK003-NOT: "-internal-externc-isystem" "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/hexagon/include"<br>
> +// CHECK003-NEXT: "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/bin/hexagon-as"<br>
> +<br>
> +// RUN: %clang -### -target hexagon-unknown-linux \<br>
> +// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/qc/bin \<br>
> +// RUN: -nostdlibinc \<br>
> +// RUN: %s 2>&1 \<br>
> +// RUN: | FileCheck -check-prefix=CHECK004 %s<br>
> +// CHECK004: "-cc1"<br>
> +// CHECK004-NOT: "-internal-externc-isystem" "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/lib/gcc/hexagon/4.4.0/include"<br>
> +// CHECK004-NOT: "-internal-externc-isystem" "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/lib/gcc/hexagon/4.4.0/include-fixed"<br>
> +// CHECK004-NOT: "-internal-externc-isystem" "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/hexagon/include"<br>
> +// CHECK004-NEXT: "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/bin/hexagon-as"<br>
> +<br>
> +// RUN: %clang -ccc-cxx -x c++ -### -target hexagon-unknown-linux \<br>
> +// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/qc/bin \<br>
> +// RUN: -nostdlibinc \<br>
> +// RUN: %s 2>&1 \<br>
> +// RUN: | FileCheck -check-prefix=CHECK005 %s<br>
> +// CHECK005: "-cc1"<br>
> +// CHECK005-NOT: "-internal-isystem" "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/hexagon/include/c++/4.4.0"<br>
> +// CHECK005-NOT: "-internal-externc-isystem" "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/lib/gcc/hexagon/4.4.0/include"<br>
> +// CHECK005-NOT: "-internal-externc-isystem" "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/lib/gcc/hexagon/4.4.0/include-fixed"<br>
> +// CHECK005-NOT: "-internal-externc-isystem" "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/hexagon/include"<br>
> +// CHECK005-NEXT: "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/bin/hexagon-as"<br>
> +<br>
> +// RUN: %clang -ccc-cxx -x c++ -### -target hexagon-unknown-linux \<br>
> +// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/qc/bin \<br>
> +// RUN: -nostdinc++ \<br>
> +// RUN: %s 2>&1 \<br>
> +// RUN: | FileCheck -check-prefix=CHECK006 %s<br>
> +// CHECK006: "-cc1"<br>
> +// CHECK006-NOT: "-internal-isystem" "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/hexagon/include/c++/4.4.0"<br>
> +// CHECK006-NEXT: "{{.*}}/Inputs/hexagon_tree/qc/bin/../../gnu/bin/hexagon-as"<br>
> --<br>
> 1.7.8.3<br>
<div class="im HOEnZb">><br>
<br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
<br>
</div><span class="HOEnZb"><font color="#888888">Sebastian<br>
</font></span><div class="HOEnZb"><div class="h5">--<br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation<br>
</div></div></blockquote></div><br></div>