<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Sep 17, 2012, at 3:38 PM, Richard Smith wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">On Mon, Sep 17, 2012 at 12:15 PM, Fariborz Jahanian <span dir="ltr"><<a href="mailto:fjahanian@apple.com" target="_blank">fjahanian@apple.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: fjahanian<br>
Date: Mon Sep 17 14:15:26 2012<br>
New Revision: 164047<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=164047&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=164047&view=rev</a><br>
Log:<br>
objective-C: issue warning when there is no whitespace<br>
between objc method parameter name and colon.<br>
// <a href="rdar://12263549">rdar://12263549</a><br>
<br>
Added:<br>
cfe/trunk/test/SemaObjC/warning-missing-selector-name.m<br>
Modified:<br>
cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td<br>
cfe/trunk/lib/Parse/ParseObjc.cpp<br>
cfe/trunk/test/SemaObjC/unused.m<br>
<br>
Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td?rev=164047&r1=164046&r2=164047&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td?rev=164047&r1=164046&r2=164047&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td (original)<br>
+++ cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td Mon Sep 17 14:15:26 2012<br>
@@ -213,6 +213,12 @@<br>
"expected ';' after static_assert">;<br>
def err_expected_semi_for : Error<"expected ';' in 'for' statement specifier">;<br>
def err_expected_colon_after : Error<"expected ':' after %0">;<br>
+def missing_selector_name : Warning<<br>
+ "parameter name used as selector"<br>
+ " may result in incomplete method selector name">,<br>
+ InGroup<DiagGroup<"missing-argument-name-in-selector">>;<br></blockquote><div><br></div><div>You're missing the "warn_" from this warning name.</div></div>
</blockquote>Fixed in r164077.</div><div>- fariborz</div><div><br></div><br></body></html>