On Mon, Sep 17, 2012 at 7:26 AM, Axel Naumann <span dir="ltr"><<a href="mailto:Axel.Naumann@cern.ch" target="_blank">Axel.Naumann@cern.ch</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: axel<br>
Date: Mon Sep 17 09:26:53 2012<br>
New Revision: 164033<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=164033&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=164033&view=rev</a><br>
Log:<br>
Don't write uninitialized values even if nobody ever asks for it.<br></blockquote><div><br></div><div>It's not clear to me what the purpose of this change was: the variable is initialized by every case in the following switch, except the one with an llvm_unreachable. With this change, we'll not get a warning if one of the switch cases misses the initialization of the variable.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Modified:<br>
    cfe/trunk/lib/Sema/SemaDeclCXX.cpp<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclCXX.cpp?rev=164033&r1=164032&r2=164033&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclCXX.cpp?rev=164033&r1=164032&r2=164033&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaDeclCXX.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaDeclCXX.cpp Mon Sep 17 09:26:53 2012<br>
@@ -4086,7 +4086,7 @@<br>
<br>
   // Compute argument constness, constexpr, and triviality.<br>
   bool CanHaveConstParam = false;<br>
-  bool Trivial;<br>
+  bool Trivial = false;<br>
   switch (CSM) {<br>
   case CXXDefaultConstructor:<br>
     Trivial = RD->hasTrivialDefaultConstructor();<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br>