Dear all,<br><br> There's the rebased new patch to follow the test input change.<br>Every code remained unchanged. Please have a look. Thanks.<br><br>Logan<br><br>FYI. <a href="https://github.com/loganchien/clang-logan/commit/058214185f98390a19cf744a654ec0b584e1f300">https://github.com/loganchien/clang-logan/commit/058214185f98390a19cf744a654ec0b584e1f300</a><br>
<br><div class="gmail_quote">On Wed, Aug 29, 2012 at 5:46 PM, Logan Chien <span dir="ltr"><<a href="mailto:tzuhsiang.chien@gmail.com" target="_blank">tzuhsiang.chien@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks for your comments. Here's the new patch. The test cases is included<br>now.<br><br>However, IMHO, this new test case is not very reliable. The GCCInstallationDetector<br>will search for system root (i.e. /usr) for latest (newest) GCC, thus "-B" option may not<br>
be used if we have older GCC version in the test case. Maybe we have to revise the<br>"-B" implementation as well.<br><br>Any further suggestion? Thanks.<br><br>Sincerely,<br>Logan<div class="HOEnZb"><div class="h5">
<br><br><div class="gmail_quote">
On Wed, Aug 29, 2012 at 3:23 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
If you want to teach the Clang driver about the android toolchains, you'll need to add some test cases for them. You can find the test case strategy by looking at the tests for Linux and FreeBSD; I think they're pretty comprehensive at this point.<div class="gmail_extra">
<br><br><div class="gmail_quote"><div><div>On Wed, Aug 29, 2012 at 12:19 AM, Logan Chien <span dir="ltr"><<a href="mailto:tzuhsiang.chien@gmail.com" target="_blank">tzuhsiang.chien@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
Hi,<br><br> Currently, the GCCInstallationDetector is not looking for mipsel-linux-android and<br>i686-linux-android. As the result, the clang driver can't use Android Mips/X86 toolchain<br>even if -B is specified. I hope this patch can solve this issue. Please review. Thanks.<br>
<br>Sincerely,<br>Logan<br>
<br></div></div>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br>
</div></div></blockquote></div><br>