I could definitely try to find a number of other solutions, but unfortunately it would be not fast, as I don't have a configuration that allows to reproduce this issue, and I would have to ask the original reporter to verify each version. And, after all, is this solution that bad? What problems can it lead to?<br>
<br><div class="gmail_quote">On Mon, Sep 10, 2012 at 5:23 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">On Mon, Sep 10, 2012 at 7:54 AM, Alexander Kornienko <<a href="mailto:alexfh@google.com">alexfh@google.com</a>> wrote:<br>
> Author: alexfh<br>
> Date: Mon Sep 10 09:54:38 2012<br>
> New Revision: 163513<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=163513&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=163513&view=rev</a><br>
> Log:<br>
> Workaround for MacOSX build failure with gcc <= 4.4<br>
><br>
> Summary:<br>
> A better solution to <a href="http://llvm.org/bugs/show_bug.cgi?id=13777" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=13777</a><br>
> Named namespace + more unique name to make ODR violations unlikely.<br>
><br>
> Reviewers: chandlerc, doug.gregor, klimek<br>
><br>
> Reviewed By: doug.gregor<br>
><br>
> CC: cfe-commits<br>
><br>
> Differential Revision: <a href="http://llvm-reviews.chandlerc.com/D38" target="_blank">http://llvm-reviews.chandlerc.com/D38</a><br>
><br>
> Modified:<br>
> cfe/trunk/tools/clang-check/ClangCheck.cpp<br>
><br>
> Modified: cfe/trunk/tools/clang-check/ClangCheck.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-check/ClangCheck.cpp?rev=163513&r1=163512&r2=163513&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-check/ClangCheck.cpp?rev=163513&r1=163512&r2=163513&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/tools/clang-check/ClangCheck.cpp (original)<br>
> +++ cfe/trunk/tools/clang-check/ClangCheck.cpp Mon Sep 10 09:54:38 2012<br>
> @@ -58,10 +58,10 @@<br>
> "ast-dump-filter",<br>
> cl::desc(Options->getOptionHelpText(options::OPT_ast_dump_filter)));<br>
><br>
> -// Anonymous namespace here causes problems with gcc <= 4.4 on MacOS:<br>
> -// <a href="http://llvm.org/bugs/show_bug.cgi?id=13777" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=13777</a><br>
> -// namespace {<br>
> -class ActionFactory {<br>
> +// Anonymous namespace here causes problems with gcc <= 4.4 on MacOS 10.6.<br>
> +// "Non-global symbol: ... can't be a weak_definition"<br>
<br>
</div></div>Judging by that diagnostic - is it possible that making the<br>
newASTConsumer member function non-inline would have been an<br>
alternative fix to the code?<br>
<div class="HOEnZb"><div class="h5"><br>
> +namespace clang_check {<br>
> +class ClangCheckActionFactory {<br>
> public:<br>
> clang::ASTConsumer *newASTConsumer() {<br>
> if (ASTList)<br>
> @@ -73,10 +73,10 @@<br>
> return new clang::ASTConsumer();<br>
> }<br>
> };<br>
> -// }<br>
> +}<br>
><br>
> int main(int argc, const char **argv) {<br>
> - ActionFactory Factory;<br>
> + clang_check::ClangCheckActionFactory Factory;<br>
> CommonOptionsParser OptionsParser(argc, argv);<br>
> ClangTool Tool(OptionsParser.GetCompilations(),<br>
> OptionsParser.GetSourcePathList());<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div><font color="#666666"><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(213,15,37);border-right-color:rgb(213,15,37);border-bottom-color:rgb(213,15,37);border-left-color:rgb(213,15,37);padding-top:2px;margin-top:2px">Alexander Kornienko |</span><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(51,105,232);border-right-color:rgb(51,105,232);border-bottom-color:rgb(51,105,232);border-left-color:rgb(51,105,232);padding-top:2px;margin-top:2px"> Software Engineer |</span></font><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(0,153,57);border-right-color:rgb(0,153,57);border-bottom-color:rgb(0,153,57);border-left-color:rgb(0,153,57);padding-top:2px;margin-top:2px"><font color="#666666"> </font><a href="mailto:alexfh@google.com" style="color:rgb(17,85,204)" target="_blank">alexfh@google.com</a> |</span><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(238,178,17);border-right-color:rgb(238,178,17);border-bottom-color:rgb(238,178,17);border-left-color:rgb(238,178,17);padding-top:2px;margin-top:2px"> <a value="+35315435283" style="color:rgb(17,85,204)">+49 151 221 77 957</a></span></div>
</div><div><font color="#666666"><span style="background-color:rgb(255,255,255);font-family:Arial,Verdana,sans-serif">Google Germany GmbH | </span><span style="background-color:rgb(255,255,255);font-family:Arial,Verdana,sans-serif">Dienerstr. 12 | </span><span style="background-color:rgb(255,255,255);font-family:Arial,Verdana,sans-serif">80331 München</span></font></div>
<br>