<div class="gmail_extra"><div class="gmail_quote">On Sat, Sep 8, 2012 at 12:28 AM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank" class="cremed">richard@metafoo.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Sat, Sep 8, 2012 at 12:18 AM, Ted Kremenek <span dir="ltr"><<a href="mailto:kremenek@apple.com" target="_blank" class="cremed">kremenek@apple.com</a>></span> wrote:<br>
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

Author: kremenek<br>
Date: Sat Sep  8 02:18:18 2012<br>
New Revision: 163460<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=163460&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=163460&view=rev</a><br>
Log:<br>
Fix bug in BugReporter::RemoveUneededCalls() where "prunable"<br>
PathDiagnosticEventPieces were *always* pruned.  Instead, they<br>
are suppose to only be pruned if the entire call gets pruned.<br>
<br>
Modified:<br>
    cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp<br>
    cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp<br>
    cfe/trunk/test/Analysis/malloc-plist.c<br>
    cfe/trunk/test/Analysis/plist-output-alternate.m<br>
    cfe/trunk/test/Analysis/plist-output.m<br>
    cfe/trunk/test/Analysis/retain-release.m</blockquote><div><br></div><div>Analysis/retain-release.m has been failing nondeterministically since r163455 (maybe before). Can you take a look? At r163460, the failure looks like this:</div>

<div><br></div><div><div>src/tools/clang/test/Analysis/retain-release.m:13645:16: error: CHECK-NEXT: is not on the line after the previous match</div><div>// CHECK-NEXT: <key>kind</key><string>control</string></div>

<div>               ^</div><div>build/tools/clang/test/Analysis/Output/retain-release.m.tmp.objcpp.plist:11772:2: note: 'next' match was here</div><div> <key>kind</key><string>control</string></div>

<div> ^</div><div>build/tools/clang/test/Analysis/Output/retain-release.m.tmp.objcpp.plist:11728:8: note: previous match was here</div><div> <dict></div><div>       ^</div></div></div></blockquote><div><br></div><div>
I was actually writing a reply to that commit (163455). We should keep the discussion there. Ted has been trying to stabilize this for quite a few commits now, and I think it's just not quite working yet.</div></div></div>