<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">I like it! Thank you for doing this.<br>
<br>
Specifically, I like how it defaults to strict and users must
explicitly choose to pull out a foot gun.<br>
<br>
There's probably potential for hooking up
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
clang_getClangVersion() to make the compatibility check even
stricter. I'm think that the Python bindings would contain a
minimal libclang version. This way, if function semantics ever
change between libclang releases (I know the API is supposed to be
backwards compatible, but you never know), we can detect that.
Don't let this hold up committing this patch though.<br>
<br>
On 9/5/12 2:01 AM, Tobias Grosser wrote:<br>
</div>
<blockquote cite="mid:504714E3.8040807@grosser.es" type="cite">Hi,
<br>
<br>
I would like to commit the attached patch. Here the intended
<br>
commit message:
<br>
<br>
----------------------
<br>
[cindex.py] Make the use of a compatibilty check explicit
<br>
<br>
At the moment, we implictly check compatibility between the python
<br>
bindings and libclang, as the python bindings will fail to load in
case
<br>
a method we use in libclang is not available.
<br>
<br>
This patch makes the use of this compatibility check explicit and
<br>
introduces a flag to optionally disable the check. This will allow
us to
<br>
further harden the compatibility check, but it also gives the user
the
<br>
possibility to disable the compatibility check to evaluate
compatibility
<br>
with older libclang versions.
<br>
<br>
I added documentation that makes clear the python bindings are
only
<br>
tested with the libclang version they have been shipped with.
<br>
----------------------
<br>
<br>
Gregory raised in a recent discussion concerns about silently
removing
<br>
the compatibility check. I took this as a motivation to make the
check
<br>
even more explicit, but also introduced an option to disable it if
<br>
explicitly demanded. I hope this patch can cater both sides, the
users
<br>
who want to experiment with multi-version compatibility and the
users
<br>
who aim for an even stricter compatibility check.
<br>
<br>
OK to commit?
<br>
<br>
Tobi
<br>
</blockquote>
<br>
</body>
</html>