<div class="gmail_extra"><div class="gmail_quote">On Tue, Sep 4, 2012 at 9:42 AM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank" class="cremed">thakis@chromium.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_quote"><div class="im">On Sat, Sep 1, 2012 at 5:48 PM, Joao Matos <span dir="ltr"><<a href="mailto:ripzonetriton@gmail.com" target="_blank" class="cremed">ripzonetriton@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: triton<br>
Date: Sat Sep  1 19:48:08 2012<br>
New Revision: 163079<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=163079&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=163079&view=rev</a><br>
Log:<br>
Include the diagnostic introduced in r163078 in a group.<br></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Modified:<br>
    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
<br>
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=163079&r1=163078&r2=163079&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=163079&r1=163078&r2=163079&view=diff</a><br>


==============================================================================<br>
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)<br>
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Sat Sep  1 19:48:08 2012<br>
@@ -1674,8 +1674,7 @@<br>
   "\"local-dynamic\", \"initial-exec\" or \"local-exec\"">;<br>
 def warn_ms_inheritance_already_declared : Warning<<br>
   "ignored since inheritance model was already declared as '"<br>
-  "%select{single|multiple|virtual}0'">;<br>
-<br>
+  "%select{single|multiple|virtual}0'">, InGroup<Microsoft>;<br></blockquote><div><br></div></div><div>As far as I understand, -Wmicrosoft warns about things that aren't valid code which are permitted in microsoft mode. This diagnostic probably doesn't belong into this group.</div>
</div></blockquote><div><br></div><div>Also, please get pre-commit review on patches that aren't obvious -- this one doesn't seem to be.</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_quote"><div class="im">
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 def err_only_annotate_after_access_spec : Error<<br>
   "access specifier can only have annotation attributes">;<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank" class="cremed">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div><br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" class="cremed">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>