<div class="gmail_extra"><div class="gmail_quote">On Mon, Sep 3, 2012 at 6:41 AM, Joao Matos <span dir="ltr"><<a href="mailto:ripzonetriton@gmail.com" target="_blank" class="cremed">ripzonetriton@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: triton<br>
Date: Mon Sep  3 05:41:45 2012<br>
New Revision: 163113<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=163113&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=163113&view=rev</a><br>
Log:<br>
Improved the warning for the #@ Microsoft charizing operator. The existing one misspelled the token as "@#" and didn't capitalize Microsoft.<br></blockquote><div><br></div><div>Again, please get pre-commit review until you are certain you understand the requirements to submit a patch directly.</div>
<div><br></div><div>Specifically, you need to include test cases for diagnostic changes like this. Please add several, as we can't have had thorough coverage if this didn't break any existing test cases.</div><div>
<br></div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td<br>
<br>
Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td?rev=163113&r1=163112&r2=163113&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td?rev=163113&r1=163112&r2=163113&view=diff</a><br>


==============================================================================<br>
--- cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td (original)<br>
+++ cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td Mon Sep  3 05:41:45 2012<br>
@@ -55,7 +55,7 @@<br>
<br>
 def ext_dollar_in_identifier : Extension<"'$' in identifier">,<br>
   InGroup<DiagGroup<"dollar-in-identifier-extension">>;<br>
-def ext_charize_microsoft : Extension<"@# is a microsoft extension">,<br>
+def ext_charize_microsoft : Extension<"charizing operator #@ is a Microsoft extension">,<br>
   InGroup<Microsoft>;<br>
<br>
 def ext_token_used : Extension<"extension used">,<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank" class="cremed">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>