<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">I like it! This is much needed.<br>
<br>
My initial thoughts were that the Config class is a bit
heavyweight. IMO a module-level function to force reload the
global lib instance to point to a different library would be
sufficient. But, thinking it through, I'm not sure how this could
be done without making things weird. The best I can think of is
that at module load time it would attempt to find a library. If it
doesn't, lib is None and the first use of functionality results in
an opaque message about None not having some attribute. If someone
wished to point to a non-default path, they could import the
module and call a function which replaced the module variable
"lib." But, this is essentially what you have coded in the Config
class. So, I guess the extra complexity is warranted. That being
said, I'm not convinced a class is needed (a few module-level
functions and variable would suffice, IMO). But, I don't feel too
strongly, so LGTM.<br>
<br>
On 8/31/2012 4:18 AM, Tobias Grosser wrote:<br>
</div>
<blockquote cite="mid:50409D75.2090800@grosser.es" type="cite">Hi,
<br>
<br>
I would like to commit the following patch:
<br>
<br>
---------------------------------------------------------------------
<br>
[cindex.py] Allow to configure the path of libclang
<br>
<br>
By calling cindex.Config.set_library_path(path) or
cindex.Config.set_library_file(file) it is possible to specify
from where we load libclang. This fixes an open FIXME.
<br>
---
<br>
bindings/python/clang/cindex.py | 315
+++++++++++++++++++++++----------------
<br>
1 file changed, 183 insertions(+), 132 deletions(-)
<br>
---------------------------------------------------------------------
<br>
<br>
Any comments or concerns?
<br>
<br>
Tobi
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
cfe-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>