Looks good, please commit.<div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 28, 2012 at 1:47 PM, Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" target="_blank">aaron@aaronballman.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Tue, Aug 28, 2012 at 4:19 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:<br>

> Index: lib/Sema/DeclSpec.cpp<br>
> ===================================================================<br>
> --- lib/Sema/DeclSpec.cpp (revision 162690)<br>
> +++ lib/Sema/DeclSpec.cpp (working copy)<br>
> @@ -325,10 +325,17 @@<br>
><br>
>  template <class T> static bool BadSpecifier(T TNew, T TPrev,<br>
>                                              const char *&PrevSpec,<br>
> -                                            unsigned &DiagID) {<br>
> +                                            unsigned &DiagID,<br>
> +                                            bool Pedantic = true) {<br>
><br>
> How about "IsExtension"?<br>
><br>
>    PrevSpec = DeclSpec::getSpecifierName(TPrev);<br>
> -  DiagID = (TNew == TPrev ? diag::ext_duplicate_declspec<br>
> -            : diag::err_invalid_decl_spec_combination);<br>
> +  if (TNew == TPrev) {<br>
> +    if (Pedantic)<br>
> +      DiagID = diag::ext_duplicate_declspec;<br>
> +    else<br>
> +      DiagID = diag::warn_duplicate_declspec;<br>
> +  } else {<br>
> +    DiagID = diag::err_invalid_decl_spec_combination;<br>
> +  }<br>
><br>
> Would early exit make this cleaner?<br>
<br>
</div>Attached with latest suggestions.<br>
<span class="HOEnZb"><font color="#888888"><br>
~Aaron<br>
</font></span></blockquote></div><br></div>