<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Aug 13, 2012, at 12:08 AM, Daniel Jasper <<a href="mailto:djasper@google.com">djasper@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Hi Doug,<div><br></div><div>could you take a look at the patch? It mostly moves stuff around (putting the JSONCompilationDatabase into its own files) and implements the described design.</div></blockquote><div><br></div><div>As noted on IRC, this looks great to me. Thanks!</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div><br><blockquote type="cite"><div>Cheers,<br>
Daniel</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 31, 2012 at 7:54 AM, Douglas Gregor <span dir="ltr"><<a href="mailto:dgregor@apple.com" target="_blank">dgregor@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
On Jul 30, 2012, at 4:09 AM, Manuel Klimek <<a href="mailto:klimek@google.com">klimek@google.com</a>> wrote:<br>
<br>
> On Mon, Jul 30, 2012 at 12:39 PM, Konstantin Tokarev <<a href="mailto:annulen@yandex.ru">annulen@yandex.ru</a>> wrote:<br>
>><br>
>><br>
>>> Hi Doug,<br>
>>><br>
>>> any chance I could get this reviewed? I have another feature for the compilation database (correctly handling relative directories) that I would like to implement in the new structure.<br>
>><br>
>> Sorry if I didn't understand something, but is there any real-world use case where these plugins are needed?<br>
><br>
> We implemented it because we have a use case :) For example, we have a<br>
> server-based build system at Google that we want to query, where the<br>
> compilation database implementation depends on internal system<br>
> libraries that we cannot open source (mainly because it's not written<br>
> in a generic enough way). We have developers working in open source<br>
> land, and inside Google land, and we want to have one set of tools<br>
> that "just works".<br>
<br>
</div></div>And Google is not alone in having their own in-house build systems that would benefit from such a plugin system.<br>
</blockquote></div><br></div>
</blockquote></div><br></body></html>