<br><br><div class="gmail_quote">On Tue, Aug 14, 2012 at 7:50 AM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: d0k<br>
Date: Tue Aug 14 09:50:32 2012<br>
New Revision: 161872<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=161872&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=161872&view=rev</a><br>
Log:<br>
Do NOT use inline functions with LLVM_ATTRIBUTE_USED.<br>
<br>
The function will be emitted into every single TU including the header!<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/AST/DeclBase.h<br>
    cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h<br>
    cfe/trunk/lib/AST/DeclPrinter.cpp<br>
    cfe/trunk/lib/AST/DumpXML.cpp<br>
    cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp<br>
<br>
Modified: cfe/trunk/include/clang/AST/DeclBase.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclBase.h?rev=161872&r1=161871&r2=161872&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclBase.h?rev=161872&r1=161871&r2=161872&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/include/clang/AST/DeclBase.h (original)<br>
+++ cfe/trunk/include/clang/AST/DeclBase.h Tue Aug 14 09:50:32 2012<br>
@@ -858,10 +858,10 @@<br>
                          raw_ostream &Out, const PrintingPolicy &Policy,<br>
                          unsigned Indentation = 0);<br>
   // Debuggers don't usually respect default arguments.<br>
-  LLVM_ATTRIBUTE_USED void dump() const { dump(llvm::errs()); }<br>
+  LLVM_ATTRIBUTE_USED void dump() const;<br>
   void dump(raw_ostream &Out) const;<br>
   // Debuggers don't usually respect default arguments.<br>
-  LLVM_ATTRIBUTE_USED void dumpXML() const { dumpXML(llvm::errs()); }<br>
+  LLVM_ATTRIBUTE_USED void dumpXML() const;<br>
   void dumpXML(raw_ostream &OS) const;<br>
<br>
 private:<br>
<br>
Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h?rev=161872&r1=161871&r2=161872&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h?rev=161872&r1=161871&r2=161872&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h (original)<br>
+++ cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h Tue Aug 14 09:50:32 2012<br>
@@ -328,7 +328,7 @@<br>
<br>
   // For debugging purposes only<br>
   void dump(raw_ostream &Out) const;<br>
-  LLVM_ATTRIBUTE_USED void dump() const { dump(llvm::errs()); }<br>
+  LLVM_ATTRIBUTE_USED void dump() const;<br>
<br>
   static bool classof(const CallEvent *) { return true; }<br>
 };<br>
<br>
Modified: cfe/trunk/lib/AST/DeclPrinter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/DeclPrinter.cpp?rev=161872&r1=161871&r2=161872&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/DeclPrinter.cpp?rev=161872&r1=161871&r2=161872&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/AST/DeclPrinter.cpp (original)<br>
+++ cfe/trunk/lib/AST/DeclPrinter.cpp Tue Aug 14 09:50:32 2012<br>
@@ -175,6 +175,10 @@<br>
   Printer.VisitDeclContext(const_cast<DeclContext *>(this), /*Indent=*/false);<br>
 }<br>
<br>
+void Decl::dump() const {<br>
+  dump(llvm::errs());<br>
+}<br>
+<br>
 void Decl::dump(raw_ostream &Out) const {<br>
   PrintingPolicy Policy = getASTContext().getPrintingPolicy();<br>
   Policy.Dump = true;<br>
<br>
Modified: cfe/trunk/lib/AST/DumpXML.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/DumpXML.cpp?rev=161872&r1=161871&r2=161872&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/DumpXML.cpp?rev=161872&r1=161871&r2=161872&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/AST/DumpXML.cpp (original)<br>
+++ cfe/trunk/lib/AST/DumpXML.cpp Tue Aug 14 09:50:32 2012<br>
@@ -1022,12 +1022,17 @@<br>
 };<br>
 }<br>
<br>
+void Decl::dumpXML() const {<br>
+  dump(llvm::errs());<br></blockquote><div>You definitely want to call dumpXML(llvm::errs()) here.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+}<br>
+<br>
 void Decl::dumpXML(raw_ostream &out) const {<br>
   XMLDumper(out, getASTContext()).dispatch(const_cast<Decl*>(this));<br>
 }<br>
<br>
 #else /* ifndef NDEBUG */<br>
<br>
+void Decl::dumpXML() const {}<br>
 void Decl::dumpXML(raw_ostream &out) const {}<br>
<br>
 #endif<br>
<br>
Modified: cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp?rev=161872&r1=161871&r2=161872&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp?rev=161872&r1=161871&r2=161872&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp (original)<br>
+++ cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp Tue Aug 14 09:50:32 2012<br>
@@ -207,6 +207,10 @@<br>
   return ArgE->getSourceRange();<br>
 }<br>
<br>
+void CallEvent::dump() const {<br>
+  dump(llvm::errs());<br>
+}<br>
+<br>
 void CallEvent::dump(raw_ostream &Out) const {<br>
   ASTContext &Ctx = getState()->getStateManager().getContext();<br>
   if (const Expr *E = getOriginExpr()) {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>
<div>Best regards,</div><div>Alexander Kornienko</div>