<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Aug 14, 2012, at 2:32 PM, Richard Trieu <<a href="mailto:rtrieu@google.com">rtrieu@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><blockquote class="gmail_quote" style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; "><div style="word-wrap: break-word; ">At a high level, I honestly find this logic to be more complicated than I would have expected. The sorting seems unnecessary, and will report diagnostics in an unnatural order (first based on enum constant value, then on declaration order). A straight linear pass seems more naturally to me, and DenseMap is very efficient.</div></blockquote><div style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; ">Is there a comparison between the different containers in LLVM and the STL containers?</div></blockquote><br></div><div>This is a reasonable place to start:</div><div><br></div><div> <a href="http://llvm.org/docs/ProgrammersManual.html#ds_map">http://llvm.org/docs/ProgrammersManual.html#ds_map</a></div><div><br></div><div>The key with DenseMap is that it is probed hashtable. There is one big allocation for the entire table, instead of a bunch of buckets. When applicable, it can be very fast, and feels like the right data structure to use here.</div></body></html>