<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Aug 9, 2012, at 2:33 PM, Chandler Carruth wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote">On Thu, Aug 9, 2012 at 2:29 PM, Chad Rosier <span dir="ltr"><<a href="mailto:mcrosier@apple.com" target="_blank">mcrosier@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><br><div><div><div>On Aug 9, 2012, at 2:25 PM, Chandler Carruth wrote:</div><br><blockquote type="cite">Why two bits? Couldn't we say that there are two dialects, the default is ATT, and there is a bit to select the intel dialect?</blockquote>
<div><br></div></div><div>I'm fine with that approach.</div><div><br><blockquote type="cite"><div>Do you expect us to ever need to have the IR model more dialects?</div></blockquote><div><br></div></div><div>
I don't expect it, but it's not out of the realm of possibilities.</div></div></div></blockquote><div><br></div><div>Ok, not sure how much future-proofing you want to do here…</div></div></div></blockquote><div><br></div><div>Agreed.</div><br><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote"><div>If we're going to want more than 2 dialects, I would have the one bit say "non-standard dialect" and store which dialect in a side structure that can be omitted in most cases.</div>
<div><br></div><div>I suspect that this would be a graceful progression though:</div><div><br></div><div>Today: 1 bit, if it is set, "other" dialect is used. No need for side datastructure if the other dialect happens to be the Intel dialect. So we don't even include the side data structure.</div></div></div></blockquote><div><br></div><div>Sounds fine.</div><br><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote"><div>Future: We add the side datastructure, and if there is no further information there, assume Intel.</div></div></div></blockquote><div><br></div><div>The underlying data structure of the Attribute class is a bit vector. Adding a side data structure would fundamentally change this class… but I don't think it's something we need to worry about..</div><br><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>The patches LGTM with the changes discussed. Comment appropriately the single-bit flag semantics of course. ;]</div></div></div></blockquote><div><br></div><div>Will do.</div><br><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote">
<div>Could you test (and implement) both ATT and Intel dialect setting in Clang?</div></div></div>
</blockquote></div><br><div>I believe I have enough of the code in place now to do proper testing.. so, sure!</div><div><br></div><div>Thanks for the feedback, Chandler.</div><div><br></div><div> Chad</div></body></html>