LGTM<div><br></div><div>We may need it in more places, but we can do that iteratively.</div><div><br></div><div>No ' ' after the open '(' though: 'set(FOO' is the more common style.</div><div><br></div>
<div>Thanks!</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Aug 8, 2012 at 5:00 PM, Chad Rosier <span dir="ltr"><<a href="mailto:mcrosier@apple.com" target="_blank">mcrosier@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Chandler,<div>How does the attached patch look?</div><span class="HOEnZb"><font color="#888888"><div>
<br></div><div> Chad</div><div><br></div><div></div></font></span></div>
<br><div style="word-wrap:break-word"><div></div><div><br></div><div><br><div><div>On Aug 8, 2012, at 9:32 AM, Chandler Carruth wrote:</div><br><blockquote type="cite"><p dir="ltr">CMake? Can I help with those changes?</p>
<div class="gmail_quote">On Aug 8, 2012 9:29 AM, "Chad Rosier" <<a href="mailto:mcrosier@apple.com" target="_blank">mcrosier@apple.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: mcrosier<br>
Date: Wed Aug 8 11:27:29 2012<br>
New Revision: 161498<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=161498&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=161498&view=rev</a><br>
Log:<br>
Add various MC components to clang build to support MS-style inline assembly.<br>
<br>
Modified:<br>
cfe/trunk/tools/arcmt-test/Makefile<br>
cfe/trunk/tools/clang-check/Makefile<br>
cfe/trunk/tools/diagtool/Makefile<br>
cfe/trunk/tools/libclang/Makefile<br>
cfe/trunk/unittests/ASTMatchers/Makefile<br>
cfe/trunk/unittests/Frontend/Makefile<br>
cfe/trunk/unittests/Tooling/Makefile<br>
<br>
Modified: cfe/trunk/tools/arcmt-test/Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/arcmt-test/Makefile?rev=161498&r1=161497&r2=161498&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/arcmt-test/Makefile?rev=161498&r1=161497&r2=161498&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/tools/arcmt-test/Makefile (original)<br>
+++ cfe/trunk/tools/arcmt-test/Makefile Wed Aug 8 11:27:29 2012<br>
@@ -16,7 +16,8 @@<br>
# Don't install this. It is used for tests.<br>
NO_INSTALL = 1<br>
<br>
-LINK_COMPONENTS := support mc<br>
+include $(CLANG_LEVEL)/../../Makefile.config<br>
+LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc<br>
USEDLIBS = clangARCMigrate.a clangRewrite.a \<br>
clangFrontend.a clangDriver.a clangSerialization.a clangParse.a \<br>
clangSema.a clangEdit.a clangAnalysis.a clangAST.a clangLex.a \<br>
<br>
Modified: cfe/trunk/tools/clang-check/Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-check/Makefile?rev=161498&r1=161497&r2=161498&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-check/Makefile?rev=161498&r1=161497&r2=161498&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/tools/clang-check/Makefile (original)<br>
+++ cfe/trunk/tools/clang-check/Makefile Wed Aug 8 11:27:29 2012<br>
@@ -14,7 +14,8 @@<br>
# No plugins, optimize startup time.<br>
TOOL_NO_EXPORTS = 1<br>
<br>
-LINK_COMPONENTS := support mc<br>
+include $(CLANG_LEVEL)/../../Makefile.config<br>
+LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc<br>
USEDLIBS = clangFrontend.a clangSerialization.a clangDriver.a \<br>
clangTooling.a clangParse.a clangSema.a clangAnalysis.a \<br>
clangEdit.a clangAST.a clangLex.a clangBasic.a<br>
<br>
Modified: cfe/trunk/tools/diagtool/Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/diagtool/Makefile?rev=161498&r1=161497&r2=161498&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/diagtool/Makefile?rev=161498&r1=161497&r2=161498&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/tools/diagtool/Makefile (original)<br>
+++ cfe/trunk/tools/diagtool/Makefile Wed Aug 8 11:27:29 2012<br>
@@ -16,8 +16,8 @@<br>
# Don't install this.<br>
NO_INSTALL = 1<br>
<br>
-LINK_COMPONENTS := support mc<br>
-<br>
+include $(CLANG_LEVEL)/../../Makefile.config<br>
+LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc<br>
USEDLIBS = clangFrontend.a clangDriver.a clangSerialization.a clangParse.a \<br>
clangSema.a clangAnalysis.a clangEdit.a clangAST.a clangLex.a \<br>
clangBasic.a<br>
<br>
Modified: cfe/trunk/tools/libclang/Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/Makefile?rev=161498&r1=161497&r2=161498&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/Makefile?rev=161498&r1=161497&r2=161498&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/tools/libclang/Makefile (original)<br>
+++ cfe/trunk/tools/libclang/Makefile Wed Aug 8 11:27:29 2012<br>
@@ -15,7 +15,8 @@<br>
LINK_LIBS_IN_SHARED = 1<br>
SHARED_LIBRARY = 1<br>
<br>
-LINK_COMPONENTS := support mc<br>
+include $(CLANG_LEVEL)/../../Makefile.config<br>
+LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc<br>
USEDLIBS = clangARCMigrate.a clangRewrite.a clangFrontend.a clangDriver.a \<br>
clangSerialization.a \<br>
clangParse.a clangSema.a clangEdit.a clangAnalysis.a \<br>
<br>
Modified: cfe/trunk/unittests/ASTMatchers/Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/ASTMatchers/Makefile?rev=161498&r1=161497&r2=161498&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/ASTMatchers/Makefile?rev=161498&r1=161497&r2=161498&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/unittests/ASTMatchers/Makefile (original)<br>
+++ cfe/trunk/unittests/ASTMatchers/Makefile Wed Aug 8 11:27:29 2012<br>
@@ -10,7 +10,8 @@<br>
CLANG_LEVEL = ../..<br>
<br>
TESTNAME = ASTMatchers<br>
-LINK_COMPONENTS := support mc<br>
+include $(CLANG_LEVEL)/../../Makefile.config<br>
+LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc<br>
USEDLIBS = clangTooling.a clangFrontend.a clangSerialization.a clangDriver.a \<br>
clangRewrite.a clangParse.a clangSema.a clangAnalysis.a \<br>
clangAST.a clangASTMatchers.a clangLex.a clangBasic.a clangEdit.a<br>
<br>
Modified: cfe/trunk/unittests/Frontend/Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Frontend/Makefile?rev=161498&r1=161497&r2=161498&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Frontend/Makefile?rev=161498&r1=161497&r2=161498&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/unittests/Frontend/Makefile (original)<br>
+++ cfe/trunk/unittests/Frontend/Makefile Wed Aug 8 11:27:29 2012<br>
@@ -9,7 +9,8 @@<br>
<br>
CLANG_LEVEL = ../..<br>
TESTNAME = Frontend<br>
-LINK_COMPONENTS := support mc<br>
+include $(CLANG_LEVEL)/../../Makefile.config<br>
+LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc<br>
USEDLIBS = clangFrontendTool.a clangFrontend.a clangDriver.a \<br>
clangSerialization.a clangCodeGen.a clangParse.a clangSema.a \<br>
clangStaticAnalyzerCheckers.a clangStaticAnalyzerCore.a \<br>
<br>
Modified: cfe/trunk/unittests/Tooling/Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Tooling/Makefile?rev=161498&r1=161497&r2=161498&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Tooling/Makefile?rev=161498&r1=161497&r2=161498&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/unittests/Tooling/Makefile (original)<br>
+++ cfe/trunk/unittests/Tooling/Makefile Wed Aug 8 11:27:29 2012<br>
@@ -9,7 +9,8 @@<br>
<br>
CLANG_LEVEL = ../..<br>
TESTNAME = Tooling<br>
-LINK_COMPONENTS := support mc<br>
+include $(CLANG_LEVEL)/../../Makefile.config<br>
+LINK_COMPONENTS := $(TARGETS_TO_BUILD) asmparser support mc<br>
USEDLIBS = clangTooling.a clangFrontend.a clangSerialization.a clangDriver.a \<br>
clangParse.a clangRewrite.a clangSema.a clangAnalysis.a clangEdit.a \<br>
clangAST.a clangASTMatchers.a clangLex.a clangBasic.a<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</blockquote></div><br></div></div>
<br></blockquote></div><br></div>