<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">LGTM. Hoping the rewrite/merge of dump and dumpXML happens, but meanwhile this fixes the debugger problem.<div><br><div><br><div><div>On Jul 26, 2012, at 9:56 , Alexander Kornienko <<a href="mailto:alexfh@google.com">alexfh@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Please take a look at the patch.<div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jul 26, 2012 at 6:21 PM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
On Jul 26, 2012, at 9:01 , Alexander Kornienko <<a href="mailto:alexfh@google.com">alexfh@google.com</a>> wrote:<br>
<br>
> Author: alexfh<br>
> Date: Thu Jul 26 11:01:23 2012<br>
> New Revision: 160784<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=160784&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=160784&view=rev</a><br>
> Log:<br>
> Added -ast-dump-filter option to clang -cc1.<br>
><br>
> Modified:<br>
> cfe/trunk/include/clang/AST/DeclBase.h<br>
> cfe/trunk/include/clang/Driver/CC1Options.td<br>
> cfe/trunk/include/clang/Frontend/ASTConsumers.h<br>
> cfe/trunk/include/clang/Frontend/FrontendOptions.h<br>
> cfe/trunk/lib/AST/DeclPrinter.cpp<br>
> cfe/trunk/lib/AST/DumpXML.cpp<br>
> cfe/trunk/lib/Frontend/ASTConsumers.cpp<br>
> cfe/trunk/lib/Frontend/CompilerInvocation.cpp<br>
> cfe/trunk/lib/Frontend/FrontendActions.cpp<br>
><br>
> Modified: cfe/trunk/include/clang/AST/DeclBase.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclBase.h?rev=160784&r1=160783&r2=160784&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclBase.h?rev=160784&r1=160783&r2=160784&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/include/clang/AST/DeclBase.h (original)<br>
> +++ cfe/trunk/include/clang/AST/DeclBase.h Thu Jul 26 11:01:23 2012<br>
> @@ -857,9 +857,8 @@<br>
> static void printGroup(Decl** Begin, unsigned NumDecls,<br>
> raw_ostream &Out, const PrintingPolicy &Policy,<br>
> unsigned Indentation = 0);<br>
> - LLVM_ATTRIBUTE_USED void dump() const;<br>
> - LLVM_ATTRIBUTE_USED void dumpXML() const;<br>
> - void dumpXML(raw_ostream &OS) const;<br>
> + LLVM_ATTRIBUTE_USED void dump(raw_ostream &Out = llvm::errs()) const;<br>
> + LLVM_ATTRIBUTE_USED void dumpXML(raw_ostream &OS = llvm::errs()) const;<br>
<br>
</div></div>The reason why we like having a dump() without a default argument is because debuggers don't usually respect default arguments. Please put it back!<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div><font color="#666666"><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(213,15,37);border-right-color:rgb(213,15,37);border-bottom-color:rgb(213,15,37);border-left-color:rgb(213,15,37);padding-top:2px;margin-top:2px">Alexander Kornienko |</span><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(51,105,232);border-right-color:rgb(51,105,232);border-bottom-color:rgb(51,105,232);border-left-color:rgb(51,105,232);padding-top:2px;margin-top:2px"> Software Engineer |</span></font><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(0,153,57);border-right-color:rgb(0,153,57);border-bottom-color:rgb(0,153,57);border-left-color:rgb(0,153,57);padding-top:2px;margin-top:2px"><font color="#666666"> </font><a href="mailto:alexfh@google.com" style="color:rgb(17,85,204)" target="_blank">alexfh@google.com</a> |</span><span style="border-top-width:2px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-top-style:solid;border-right-style:solid;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(238,178,17);border-right-color:rgb(238,178,17);border-bottom-color:rgb(238,178,17);border-left-color:rgb(238,178,17);padding-top:2px;margin-top:2px"> <a value="+35315435283" style="color:rgb(17,85,204)">+49 151 221 77 957</a></span></div>
</div><div><font color="#666666"><span style="background-color:rgb(255,255,255);font-family:Arial,Verdana,sans-serif">Google Germany GmbH | </span><span style="background-color:rgb(255,255,255);font-family:Arial,Verdana,sans-serif">Dienerstr. 12 | </span><span style="background-color:rgb(255,255,255);font-family:Arial,Verdana,sans-serif">80331 München</span></font></div>
<br>
</div>
<span><dump.diff></span></blockquote></div><br></div></div></body></html>