<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 13, 2012, at 11:43 AM, Jordan Rose wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>This directly affects -Wobjc-literal-compare. In a private e-mail Chris suggested leaving the fixit on the warning itself (it was originally an error) since we're going to generate fairly useless code from what the user wrote 98% of the time. I (mildly) agree with Chandler about the meaning of fixits on warnings, though.</div><div><br></div><div>Currently -Wobjc-literal-compare actually DOES follow the fixit rule for ERRORS, that is, correct to use the fixit text even for CodeGen. This is not desirable behavior for this warning, but I don't know now whether to fix this by making it a note or just having Sema continue with the code as written. Chris implied the former is fine; Chandler says the latter would be preferred.</div><div><br></div><div>If we go with Chandler's interpretation (which is also what I remember from the discussion a few months ago) I'd still like to see the docs updated to point out that this needs to be <i>very</i> careful for warnings.</div></div></blockquote><br></div><div>After thinking about this a bit (too long) I can see where Chandler is coming from. Lets go with his interpretation. Thanks Jordan!</div><div><br></div><div>-Chris</div><br></body></html>