<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Sean,<br>
Thanks for your comments!<br>
<br>
On 07/18/2012 11:32 PM, Sean Silva wrote:<br>
</div>
<blockquote
cite="mid:CAHnXoa=7v3fgSbbnoRcvfS4zr31yYnoMfPH2Mv9XP5F_hnej1A@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<div>Why not</div>
<div><br>
</div>
<div>std::equal(LHS.begin(), LHS.end(), RHS.begin(), RHS.end())</div>
<div><br>
</div>
<div>?</div>
<div><br>
</div>
</blockquote>
Yes I can use std::equal, however I don't think I can gain much.<br>
<blockquote
cite="mid:CAHnXoa=7v3fgSbbnoRcvfS4zr31yYnoMfPH2Mv9XP5F_hnej1A@mail.gmail.com"
type="cite">
<div>You may also want factor in if they are the same "kind" of
DeclGroupRef (i.e. isSingleDecl vs. isDeclGroup). Once you have
that, then just compare appropriately.</div>
<div><br>
</div>
</blockquote>
I am actually comparing the "kind" of the DeclGroupRefs: see the
part isSingleDecl().<br>
<blockquote
cite="mid:CAHnXoa=7v3fgSbbnoRcvfS4zr31yYnoMfPH2Mv9XP5F_hnej1A@mail.gmail.com"
type="cite">
<div>I'm not sure exactly how best to define the equality on
DeclGroupRefs. One possibility is "they represent the same
sequence of Decl*'s", in which case, the std::equal solution
should be correct (maybe needing an isNull() check).</div>
</blockquote>
I am not sure either :) I think it makes sense to compare the
sequences of the Decl* and the Decl*'s kinds. I am attaching the new
patch.<br>
<blockquote
cite="mid:CAHnXoa=7v3fgSbbnoRcvfS4zr31yYnoMfPH2Mv9XP5F_hnej1A@mail.gmail.com"
type="cite">
<div><br>
</div>
<div>--Sean Silva<br>
</div>
</blockquote>
Vassil<br>
</body>
</html>