<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
span.gwt-inlinelabel
{mso-style-name:gwt-inlinelabel;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal>Hello,<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><pre>ARM AAPCS ABI Section 7.1.4 (<a href="http://infocenter.arm.com/help/topic/com.arm.doc.ihi0042d/IHI0042D_aapcs.pdf">http://infocenter.arm.com/help/topic/com.arm.doc.ihi0042d/IHI0042D_aapcs.pdf</a>)<o:p></o:p></pre><pre>specifies that va_list should be defined as <o:p></o:p></pre><pre>struct __va_list {<o:p></o:p></pre><pre>void *__ap;<o:p></o:p></pre><pre>}<o:p></o:p></pre><pre>And in C++, __va_list is in namespace std.<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>However, LLVM defined it as "void *__ap", which generates different mangled name for C++ code.<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>For example:<o:p></o:p></pre><pre>For the following c++ code:<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>#include <stdarg.h><o:p></o:p></pre><pre>int bar(int a, va_list args)<o:p></o:p></pre><pre>{<o:p></o:p></pre><pre>}<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>It should generate the name "_Z3bariSt9__va_list" (GCC 4.4 does that correctly).<o:p></o:p></pre><pre>But now, it generates "_Z3bariPv".<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>Therefore, there is linkage issues between LLVM and other toolchains that follow the ABI spec. <o:p></o:p></pre><pre><o:p> </o:p></pre><pre>I attached the fix and test case. (uploaded to <a href="http://llvm.org/bugs/show_bug.cgi?id=11709">http://llvm.org/bugs/show_bug.cgi?id=11709</a> as well).<o:p></o:p></pre><pre>It passes the test suite. For the unit test, no new fails. (the before/after test report is attached).<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>One thing I’m very certain is the change in <span class=gwt-inlinelabel>lib/AST/ExprClassification.cpp. Without that change, in debug build, the assertion will be triggered. <o:p></o:p></span></pre><pre><span class=gwt-inlinelabel>So I relax the condition to let __va_list to pass the check. Please let me know if there is a better solution.<o:p></o:p></span></pre><pre><span class=gwt-inlinelabel><o:p> </o:p></span></pre><pre><span class=gwt-inlinelabel>Please review the patch.<o:p></o:p></span></pre><pre><span class=gwt-inlinelabel><o:p> </o:p></span></pre><pre><span class=gwt-inlinelabel>Thanks,<o:p></o:p></span></pre><pre><span class=gwt-inlinelabel>Weiming</span><o:p></o:p></pre><pre><o:p> </o:p></pre><pre><o:p> </o:p></pre><p class=MsoNormal><o:p> </o:p></p></div></body></html>