<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 18, 2012, at 5:39 AM, Alexander Kornienko <<a href="mailto:alexfh@google.com">alexfh@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 17, 2012 at 11:56 PM, Douglas Gregor <span dir="ltr"><<a href="mailto:dgregor@apple.com" target="_blank">dgregor@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
On Jul 17, 2012, at 7:47 AM, Alexander Kornienko <<a href="mailto:alexfh@google.com">alexfh@google.com</a>> wrote:<br>
<br>
> This patch adds a custom initialize hook for clang tools. This is useful for plugging in custom initialization in private code bases and IDEs. Currently it can be used by compiling with a -DUSE_CUSTOM_TOOL_INIT and linking in an implementation for the customToolInit function.<br>
<br>
</div>This kind of #define-based hack doesn't have a lot of precedent in Clang or LLVM. What is the point of this custom initialization hook? Why does it have to be a #define hacked into the build of Clang itself (which is supposed to be a reusable *library*) rather than being introduced via a plugin or by setting some function pointer/callback somewhere?<br>
<br>
This feels very much like the wrong solution for the problem you're trying to solve, but you haven't actually told us what problem you're trying to solve.<br>
<br>
- Doug<br>
</blockquote></div><span style="font-size:13px;font-family:arial,sans-serif">You're right, we're going to find a better solution for our issue. I've removed this hook in r160432.</span><br clear="all"></div></blockquote><br></div><div>Great, thank you!</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div><br></body></html>