<div class="gmail_quote">On Wed, Jul 11, 2012 at 1:33 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Wed, Jul 11, 2012 at 1:31 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br></div><div class="gmail_extra"><div class="gmail_quote">
<div class="im">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">I have another patch locally that changed it there, but the driver has a comment that says "to do: move language stuff from frontend to driver".</p>
<div><div>
<div class="gmail_quote">On Jul 11, 2012 10:21 PM, "Richard Smith" <<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Is there a reason to put the change there rather than in CompilerInvocation::setLangDefaults? It seems like this would do the wrong thing for tools which don't use the driver.<br></blockquote></div></div></div></blockquote>
<div><br></div></div><div>Put another way, tools which don't use the driver will be quite broken in other ways too (builtin header search). The new tooling stuff should always round trip through the driver.</div></div>
</div>
</blockquote></div><br><div>I don't think this addresses my main concern. We used to have one place where the default -std= was set. We now have two, and one of them is not easy to discover. If we don't have a good reason to split this up, it should all be handled in the same place.</div>