LGTM. If someone wants to re-paint the bikeshed, they should repaint all of them. This seems a strict improvement as the number of colors goes down by one.<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 2, 2012 at 4:56 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
the attached patch renames -Wself-assign-memvar to<br>
-Wself-assign-field. matthewbg requested this, to match<br>
-Wunused-private-field.<br>
<br>
(If people don't like this, andersca points out that we should rename<br>
the flag to -Wself-assign-member-variable instead. Let me know which<br>
version you prefer.)<br>
<span class="HOEnZb"><font color="#888888"><br>
Nico<br>
</font></span><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>