Looking into this btw, thanks for the report.<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 2, 2012 at 11:00 AM, Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I'm getting this error running "check-clang" in Xcode:<br>
<br>
/usr/bin/python /utils/lit/lit.py --param clang_site_config=/Volumes/Lore/llvm-public/clang/build/test/lit.site.cfg --param clang_unit_site_config=/Volumes/Lore/llvm-public/clang/build/test/Unit/lit.site.cfg --param build_config=Debug --param build_mode=Debug --path=/Volumes/Lore/llvm-public/clang/build/test/../bin/Debug /Volumes/Lore/llvm-public/clang/build/test<br>
<br>
/usr/bin/python: can't open file '/utils/lit/lit.py': [Errno 2] No such file or directory<br>
<br>
Clearly one of the LLVM build variables is missing.<br>
<br>
This is not a standalone build, but it is a separate build from LLVM. I have CLANG_PATH_TO_LLVM_SOURCE and CLANG_PATH_TO_LLVM_BUILD set. tests/CMakeLists.txt still seems to be using PATH_TO_LLVM_* instead, though (no CLANG_ prefix).<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Jun 30, 2012, at 3:14 AM, Chandler Carruth wrote:<br>
<br>
> Author: chandlerc<br>
> Date: Sat Jun 30 05:14:27 2012<br>
> New Revision: 159483<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=159483&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=159483&view=rev</a><br>
> Log:<br>
> Switch Clang to use the new common LLVM CMake infrastructure for adding<br>
> lit testsuites. This sinks all management of the aggregate lit runs into<br>
> the LLVM CMake files, making Clang only responsible for declaring its<br>
> own testsuite. In the process we fix numerous "bugs" where the proper<br>
> method of invoking lit has changed over time, and the old system<br>
> encoded several broken artifacts of this in ABIs and compatibility<br>
> tests.<br>
><br>
> It also switches to 'check-clang' for the canonical name of the test<br>
> suite, although 'clang-test' remains as an alias.<br>
><br>
> The situation when Clang is being built in standalone mode is little<br>
> changed. It replicates just enough of the lit setup to cope with the<br>
> oddities of being run outside of an LLVM build.<br>
><br>
> Modified:<br>
> cfe/trunk/test/CMakeLists.txt<br>
><br>
> Modified: cfe/trunk/test/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CMakeLists.txt?rev=159483&r1=159482&r2=159483&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CMakeLists.txt?rev=159483&r1=159482&r2=159483&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/test/CMakeLists.txt (original)<br>
> +++ cfe/trunk/test/CMakeLists.txt Sat Jun 30 05:14:27 2012<br>
> @@ -1,3 +1,8 @@<br>
> +# Test runner infrastructure for Clang. This configures the Clang test trees<br>
> +# for use by Lit, and delegates to LLVM's lit test handlers.<br>
> +#<br>
> +# If this is a stand-alone Clang build, we fake up our own Lit support here<br>
> +# rather than relying on LLVM's.<br>
><br>
> set(CLANG_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/..")<br>
> set(CLANG_BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/..")<br>
> @@ -12,69 +17,71 @@<br>
> ${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg<br>
> )<br>
><br>
> -include(FindPythonInterp)<br>
> -if(PYTHONINTERP_FOUND)<br>
> - if( LLVM_MAIN_SRC_DIR )<br>
> - set(LIT "${LLVM_SOURCE_DIR}/utils/lit/lit.py")<br>
> - else()<br>
> - set(LIT "${PATH_TO_LLVM_BUILD}/bin/${CMAKE_CFG_INTDIR}/llvm-lit")<br>
> - # Installed LLVM does not contain ${CMAKE_CFG_INTDIR} in paths.<br>
> - if( NOT EXISTS ${LIT} )<br>
> - set(LIT "${PATH_TO_LLVM_BUILD}/bin/llvm-lit")<br>
> - endif()<br>
> - endif()<br>
> +if( PATH_TO_LLVM_BUILD )<br>
> + set(CLANG_TEST_EXTRA_ARGS "--path=${CLANG_BINARY_DIR}/bin/${CMAKE_CFG_INTDIR}")<br>
> +endif()<br>
><br>
> - if( PATH_TO_LLVM_BUILD )<br>
> - set(CLANG_TEST_EXTRA_ARGS "--path=${CLANG_BINARY_DIR}/bin/${CMAKE_CFG_INTDIR}")<br>
> +option(CLANG_TEST_USE_VG "Run Clang tests under Valgrind" OFF)<br>
> +if(CLANG_TEST_USE_VG)<br>
> + set(CLANG_TEST_EXTRA_ARGS ${CLANG_TEST_EXTRA_ARGS} "--vg")<br>
> +endif ()<br>
> +<br>
> +if( NOT CLANG_BUILT_STANDALONE )<br>
> +<br>
> + set(CLANG_TEST_DEPS<br>
> + clang clang-headers<br>
> + c-index-test diagtool arcmt-test c-arcmt-test<br>
> + clang-check<br>
> + llvm-dis llc opt FileCheck count not<br>
> + )<br>
> + if(LLVM_INCLUDE_TESTS)<br>
> + list(APPEND CLANG_TEST_DEPS ClangUnitTests)<br>
> endif()<br>
> + add_lit_testsuite(check-clang "Running the Clang regression tests"<br>
> + ${CMAKE_CURRENT_BINARY_DIR}<br>
> + PARAMS clang_site_config=${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg<br>
> + clang_unit_site_config=${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg<br>
> + DEPENDS ${CLANG_TEST_DEPS}<br>
> + ARGS ${CLANG_TEST_EXTRA_ARGS}<br>
> + )<br>
> + set_target_properties(check-clang PROPERTIES FOLDER "Clang tests")<br>
> +<br>
> +else()<br>
> +<br>
> + include(FindPythonInterp)<br>
> + if(PYTHONINTERP_FOUND)<br>
> + if( LLVM_MAIN_SRC_DIR )<br>
> + set(LIT "${LLVM_SOURCE_DIR}/utils/lit/lit.py")<br>
> + else()<br>
> + set(LIT "${PATH_TO_LLVM_BUILD}/bin/${CMAKE_CFG_INTDIR}/llvm-lit")<br>
> + # Installed LLVM does not contain ${CMAKE_CFG_INTDIR} in paths.<br>
> + if( NOT EXISTS ${LIT} )<br>
> + set(LIT "${PATH_TO_LLVM_BUILD}/bin/llvm-lit")<br>
> + endif()<br>
> + endif()<br>
><br>
> - option(CLANG_TEST_USE_VG "Run Clang tests under Valgrind" OFF)<br>
> - if(CLANG_TEST_USE_VG)<br>
> - set(CLANG_TEST_EXTRA_ARGS ${CLANG_TEST_EXTRA_ARGS} "--vg")<br>
> - endif ()<br>
> -<br>
> - set(LIT_ARGS "${CLANG_TEST_EXTRA_ARGS} ${LLVM_LIT_ARGS}")<br>
> - separate_arguments(LIT_ARGS)<br>
> -<br>
> - add_custom_target(clang-test.deps)<br>
> - set_target_properties(clang-test.deps PROPERTIES FOLDER "Clang tests")<br>
> -<br>
> - add_custom_target(clang-test<br>
> - COMMAND ${PYTHON_EXECUTABLE}<br>
> - ${LIT}<br>
> - --param clang_site_config=${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg<br>
> - --param clang_unit_site_config=${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg<br>
> - --param build_config=${CMAKE_CFG_INTDIR}<br>
> - --param build_mode=${RUNTIME_BUILD_MODE}<br>
> - ${LIT_ARGS}<br>
> - ${CMAKE_CURRENT_BINARY_DIR}<br>
> - COMMENT "Running Clang regression tests")<br>
> + set(LIT_ARGS "${CLANG_TEST_EXTRA_ARGS} ${LLVM_LIT_ARGS}")<br>
> + separate_arguments(LIT_ARGS)<br>
><br>
> - if( NOT CLANG_BUILT_STANDALONE )<br>
> - add_custom_target(check-all<br>
> + add_custom_target(check-clang<br>
> COMMAND ${PYTHON_EXECUTABLE}<br>
> - ${LIT}<br>
> - --param build_config=${CMAKE_CFG_INTDIR}<br>
> - --param build_mode=${RUNTIME_BUILD_MODE}<br>
> - ${LIT_ARGS}<br>
> - ${LLVM_BINARY_DIR}/test<br>
> - ${CMAKE_CURRENT_BINARY_DIR}<br>
> - COMMENT "Running Clang and LLVM regression tests")<br>
> - add_dependencies(check-all clang-test.deps)<br>
> - if ( LLVM_INCLUDE_TESTS )<br>
> - add_dependencies(clang-test.deps ClangUnitTests)<br>
> - add_dependencies(check-all check-llvm.deps)<br>
> - endif ( LLVM_INCLUDE_TESTS )<br>
> - add_dependencies(clang-test.deps<br>
> - llvm-dis llc opt<br>
> - FileCheck count not<br>
> - )<br>
> + ${LIT}<br>
> + --param clang_site_config=${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg<br>
> + --param clang_unit_site_config=${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg<br>
> + --param build_config=${CMAKE_CFG_INTDIR}<br>
> + --param build_mode=${RUNTIME_BUILD_MODE}<br>
> + ${LIT_ARGS}<br>
> + ${CMAKE_CURRENT_BINARY_DIR}<br>
> + COMMENT "Running Clang regression tests"<br>
> + DEPENDS clang clang-headers<br>
> + c-index-test diagtool arcmt-test c-arcmt-test<br>
> + clang-check<br>
> + )<br>
> + set_target_properties(check-clang PROPERTIES FOLDER "Clang tests")<br>
> endif()<br>
><br>
> - add_dependencies(clang-test clang-test.deps)<br>
> - add_dependencies(clang-test.deps<br>
> - clang clang-headers c-index-test diagtool arcmt-test c-arcmt-test<br>
> - clang-check<br>
> - )<br>
> -<br>
> endif()<br>
> +<br>
> +# Add a legacy target spelling: clang-test<br>
> +add_custom_target(clang-test DEPENDS check-clang)<br>
> +set_target_properties(clang-test PROPERTIES FOLDER "Clang tests")<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>