<div class="gmail_quote">On Mon, Jun 11, 2012 at 1:18 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Benjamin,<br>
<br>
in WebKit this fires on a few instances where the unused data members<br>
are used just for their size. For example:<br>
<br>
// See the function above if you need to update this.<br>
class SameSizeAsStylePropertySet : public<br>
RefCounted<SameSizeAsStylePropertySet> {<br>
    unsigned bitfield;<br>
    void* properties;<br>
};<br>
COMPILE_ASSERT(sizeof(StylePropertySet) ==<br>
sizeof(SameSizeAsStylePropertySet),<br>
style_property_set_should_stay_small);<br>
<br>
<br>
What's the recommended way to update code like that so that it doesn't<br>
trigger this warning? #pragma clang?<br></blockquote><div><br></div><div>__attribute__((unused)) should work?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<span class="HOEnZb"><font color="#888888"><br>
Nico<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Mon, Jun 11, 2012 at 9:06 AM, Benjamin Kramer<br>
<<a href="mailto:benny.kra@googlemail.com">benny.kra@googlemail.com</a>> wrote:<br>
> Author: d0k<br>
> Date: Mon Jun 11 11:06:57 2012<br>
> New Revision: 158317<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=158317&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=158317&view=rev</a><br>
> Log:<br>
> Enable -Wunused-private-field with -Wunused.<br>
><br>
> It found a lot of cruft in LLVM that I removed last week and I couldn't find any<br>
> false positives. Time to give it more testing.<br>
><br>
> Modified:<br>
>    cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>
>    cfe/trunk/test/FixIt/fixit.cpp<br>
><br>
> Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=158317&r1=158316&r2=158317&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=158317&r1=158316&r2=158317&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)<br>
> +++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Mon Jun 11 11:06:57 2012<br>
> @@ -312,7 +312,7 @@<br>
>                        [UnusedArgument, UnusedFunction, UnusedLabel,<br>
>                         // UnusedParameter, (matches GCC's behavior)<br>
>                         // UnusedMemberFunction, (clean-up llvm before enabling)<br>
> -                        // UnusedPrivateField, (clean-up llvm before enabling)<br>
> +                        UnusedPrivateField,<br>
>                         UnusedValue, UnusedVariable]>,<br>
>                         DiagCategory<"Unused Entity Issue">;<br>
><br>
><br>
> Modified: cfe/trunk/test/FixIt/fixit.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/fixit.cpp?rev=158317&r1=158316&r2=158317&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/fixit.cpp?rev=158317&r1=158316&r2=158317&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/test/FixIt/fixit.cpp (original)<br>
> +++ cfe/trunk/test/FixIt/fixit.cpp Mon Jun 11 11:06:57 2012<br>
> @@ -54,7 +54,7 @@<br>
>  }<br>
><br>
>  namespace rdar7796492 {<br>
> -  class A { int x, y; A(); };<br>
> +  struct A { int x, y; A(); };<br>
><br>
>   A::A()<br>
>     : x(1) y(2) { // expected-error{{missing ',' between base or member initializers}}<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br>