<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Jun 7, 2012, at 2:38 AM, Benjamin Kramer wrote:</div><blockquote type="cite"><div bgcolor="#FFFFFF"><div><span class="Apple-style-span" style="">On 07.06.2012, at 09:16, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</span></div><div></div><blockquote type="cite"><div><div class="gmail_quote">On Wed, Jun 6, 2012 at 11:07 PM, John McCall <span dir="ltr"><<a href="mailto:rjmccall@apple.com" target="_blank">rjmccall@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Jun 6, 2012, at 2:28 PM, Manuel Klimek wrote:<br>
> Author: klimek<br>
> Date: Wed Jun 6 16:28:13 2012<br>
> New Revision: 158112<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=158112&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=158112&view=rev</a><br>
> Log:<br>
> Switches the RewriterTestContext away from PathV1.<br>
> Now the ToolingTests all work on Windows, and they also clean up their temporary directory if they don't crash.<br>
<br>
</div>It looks like this is causing failures on release builds on darwin:<br>
<br>
******************** TEST 'Clang-Unit :: Tooling/Release/ToolingTests/Rewriter.ContinuesOverwritingFilesOnError' FAILED<br>
********************Note: Google Test filter = Rewriter.ContinuesOverwritingFilesOnError<br>
<br>
[==========] Running 1 test from 1 test case.<br>
[----------] Global test environment set-up.<br>
[----------] 1 test from Rewriter<br>
[ RUN ] Rewriter.ContinuesOverwritingFilesOnError<br>
LLVM ERROR: IO failure on output stream.<br>
<br>
********************<br>
<br>
<br>
******************** TEST 'Clang-Unit :: Tooling/Release/ToolingTests/Rewriter.OverwritesChangedFiles' FAILED<br>
********************Note: Google Test filter = Rewriter.OverwritesChangedFiles<br>
[==========] Running 1 test from 1 test case.<br>
[----------] Global test environment set-up.<br>
[----------] 1 test from Rewriter<br>
[ RUN ] Rewriter.OverwritesChangedFiles<br>
LLVM ERROR: IO failure on output stream.<br>
<br>
********************<br>
<br>
I know this isn't much to go on, sorry.</blockquote><div><br></div><div>Ugh... I don't even know how to dig into this. Manuel is on holiday, so unless you have any ideas what is causing this, you may need to just revert... </div>
</div>
</div></blockquote><div><br></div><div>The call to unique_file is side effecting but wrapped inside assert() and gets discarded in release builds. I'll fix this.</div></div></blockquote><br></div><div>Thanks, this restored the bots.</div><div><br></div><div>John.</div><br></body></html>