Doesn't that function return "error_code" not bool?<br><br><div class="gmail_quote">On Thu, Jun 7, 2012 at 2:57 AM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Thu Jun  7 04:57:21 2012<br>
New Revision: 158146<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=158146&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=158146&view=rev</a><br>
Log:<br>
Move sideeffecting call out of assert().<br>
<br>
Modified:<br>
    cfe/trunk/unittests/Tooling/RewriterTestContext.h<br>
<br>
Modified: cfe/trunk/unittests/Tooling/RewriterTestContext.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Tooling/RewriterTestContext.h?rev=158146&r1=158145&r2=158146&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Tooling/RewriterTestContext.h?rev=158146&r1=158145&r2=158146&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/unittests/Tooling/RewriterTestContext.h (original)<br>
+++ cfe/trunk/unittests/Tooling/RewriterTestContext.h Thu Jun  7 04:57:21 2012<br>
@@ -63,8 +63,10 @@<br>
   FileID createOnDiskFile(StringRef Name, StringRef Content) {<br>
     if (TemporaryDirectory.empty()) {<br>
       int FD;<br>
-      assert(!llvm::sys::fs::unique_file("rewriter-test-%%-%%-%%-%%/anchor",<br>
-                                         FD, TemporaryDirectory));<br>
+      bool error =<br>
+        llvm::sys::fs::unique_file("rewriter-test-%%-%%-%%-%%/anchor", FD,<br>
+                                   TemporaryDirectory);<br>
+      assert(!error); (void)error;<br>
       llvm::raw_fd_ostream Closer(FD, /*shouldClose=*/true);<br>
       TemporaryDirectory = llvm::sys::path::parent_path(TemporaryDirectory);<br>
     }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br><br clear="all"><br>-- <br>~Craig<br>