Any reason not to do that on all platforms? While it works on unices, I think it's nicer to not do it there, too...<br><br><div class="gmail_quote">On Sun, May 27, 2012 at 2:59 PM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chapuni<br>
Date: Sun May 27 07:59:58 2012<br>
New Revision: 157528<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=157528&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=157528&view=rev</a><br>
Log:<br>
clang/lib/Rewrite/Rewriter.cpp: Don't try to rename opened files on Win32. Win32 doesn't allow rename/removing opened files.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Rewrite/Rewriter.cpp<br>
<br>
Modified: cfe/trunk/lib/Rewrite/Rewriter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Rewrite/Rewriter.cpp?rev=157528&r1=157527&r2=157528&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Rewrite/Rewriter.cpp?rev=157528&r1=157527&r2=157528&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Rewrite/Rewriter.cpp (original)<br>
+++ cfe/trunk/lib/Rewrite/Rewriter.cpp Sun May 27 07:59:58 2012<br>
@@ -444,6 +444,10 @@<br>
     if (!ok()) return;<br>
<br>
     FileStream->flush();<br>
+#ifdef _WIN32<br>
+    // Win32 does not allow rename/removing opened files.<br>
+    FileStream.reset();<br>
+#endif<br>
     if (llvm::error_code ec =<br>
           llvm::sys::fs::rename(TempFilename.str(), Filename)) {<br>
       AllWritten = false;<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br>