First, a big thanks for helping with this stuff!<div><br></div><div>Two nits:<br>- the change to PathV2 looks like it could need a test</div><div>- SmallString<8> looks like it would basically never hit the small case for paths, I'd probably got with 128</div>
<div><br></div><div>Apart from that, looks good.</div><div><br></div><div>Cheers,</div><div>/Manuel<br><br><div class="gmail_quote">On Wed, May 23, 2012 at 2:50 AM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p>They could pass also on msvc if they were -fms-compatibility tolerant.</p>
<p>Manuel, I would be happier if you could tweak tests with -target i686-win32.<br></p>
<p>---<br>
clang/lib/Tooling/CompilationDatabase.cpp | 8 ++++++--<br>
clang/lib/Tooling/Tooling.cpp | 8 ++++++--<br>
clang/test/Tooling/clang-check-builtin-headers.cpp | 2 +-<br>
clang/test/Tooling/clang-check-chdir.cpp | 2 +-<br>
clang/test/Tooling/clang-check-pwd.cpp | 2 +-<br>
clang/test/Tooling/clang-check.cpp | 2 +-<br>
llvm/lib/Support/PathV2.cpp | 3 +++<br>
7 files changed, 19 insertions(+), 8 deletions(-)<br>
</p>
</blockquote></div><br></div>