<div class="gmail_quote">On Thu, May 3, 2012 at 2:21 PM, Jean-Daniel Dupas <span dir="ltr"><<a href="mailto:devlists@shadowlab.org" target="_blank">devlists@shadowlab.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
Recent change in CC1Options and Options definition broke the '-Wlarge-by-value-copy' argument. When trying to using it, clang cc1 failed with the following message:<br>
<br>
error: unknown argument: '-Wlarge-by-value-copy'<br>
<br>
Is this attached patch OK ?<br></blockquote><div><br></div><div>Yes, but the test case could be cleaned up.</div><br>--- /dev/null<br>+++ b/test/Driver/Wlarge-by-value-copy_opts.cpp</div><div class="gmail_quote"><br></div>
<div class="gmail_quote">I would put this in a generic test for warning options... If there isn't one yet: test/Driver/warning-options.cpp</div><div class="gmail_quote"><br>@@ -0,0 +1,4 @@<br>+// RUN: %clang -### -Wlarge-by-value-copy %s 2>&1 | FileCheck -check-prefix=WRITE-STRINGS %s<br>
+// WRITE-STRINGS: -Wlarge-by-value-copy=64</div><div class="gmail_quote"><br></div><div class="gmail_quote">WRITE-STRINGS have nothing to do with this test? Please use a more descriptive prefix rather than just copy/pasting? =D</div>
<div class="gmail_quote"><br>+// RUN: %clang -### -Wlarge-by-value-copy=128 %s 2>&1 | FileCheck -check-prefix=WRITE-STRINGS2 %s<br>+// WRITE-STRINGS2: -Wlarge-by-value-copy=128</div>