<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div></div><br><div><div>On May 3, 2012, at 6:05 PM, Chandler Carruth wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Thu, May 3, 2012 at 3:02 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Thu, May 3, 2012 at 2:56 PM, Stephen Canon <<a href="mailto:scanon@apple.com">scanon@apple.com</a>> wrote:<br>
> Clang already supports the microsoft suffixes for integer literals "i128" and "Ui128" with -fms-extensions. However, these literals are currently truncated to 64 bits with a warning.<br>
><br>
> This patch adds support for full-width 128-bit integer literals with the ms suffixes.<br>
<br>
</div>Could you include some test cases (& verify that the existing cases<br>
(the truncation warnings when the suffix isn't used, for example) are<br>
appropriately tested so that you're not regressing them)?<br></blockquote><div><br></div><div>Also, a style nit in the patch:</div><div><br></div><div><div>+ unsigned maxWidth = Context.getTargetInfo().getIntMaxTWidth();</div>
<div><br></div><div>The LLVM coding conventions suggest 'MaxWidth' for the variable name.</div><div><br></div><div>+ // The microsoft literal suffix extensions support 128-bit literals, which</div><div>+ // may be wider than [u]intmax_t.</div>
<div>+ if (Literal.isMicrosoftInteger && maxWidth < 128)</div><div>+ maxWidth = 128;</div><div>+ llvm::APInt ResultVal(maxWidth, 0);</div></div><div><br></div></div>
</blockquote></div><br></body></html>