<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On May 3, 2012, at 2:00 PM, Chandler Carruth wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Thu, May 3, 2012 at 12:50 PM, Chad Rosier <span dir="ltr"><<a href="mailto:mcrosier@apple.com" target="_blank">mcrosier@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: mcrosier<br>
Date: Thu May 3 14:50:25 2012<br>
New Revision: 156093<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=156093&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=156093&view=rev</a><br>
Log:<br>
Canonicalize loop.<br>
<br>
Modified:<br>
cfe/trunk/lib/Driver/Compilation.cpp<br>
<br>
Modified: cfe/trunk/lib/Driver/Compilation.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Compilation.cpp?rev=156093&r1=156092&r2=156093&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Compilation.cpp?rev=156093&r1=156092&r2=156093&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Driver/Compilation.cpp (original)<br>
+++ cfe/trunk/lib/Driver/Compilation.cpp Thu May 3 14:50:25 2012<br>
@@ -219,7 +219,8 @@<br>
// to avoid emitting warnings about unused args.<br>
OptSpecifier OutputOpts[] = { options::OPT_o, options::OPT_MD,<br>
options::OPT_MMD };<br>
- for (unsigned i = 0; i != sizeof(OutputOpts)/sizeof(OutputOpts[0]); ++i) {<br>
+ for (unsigned i = 0, e = sizeof(OutputOpts)/sizeof(OutputOpts[0]); i != e;<br></blockquote><div><br></div><div>Maybe use array_lengthof instead of sizeof trickery?</div><div><br></div><div><a href="http://llvm.org/docs/doxygen/html/namespacellvm.html#a370ed0e0f2bb66d17cd13f84be54e867">http://llvm.org/docs/doxygen/html/namespacellvm.html#a370ed0e0f2bb66d17cd13f84be54e867</a></div>
<div> </div></div></blockquote><div><br></div><div>Committed revision 156104. Thanks, Chandler.</div><div><br></div><div> Chad</div><div><br></div><br><blockquote type="cite"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ ++i) {<br>
if (TranslatedArgs->hasArg(OutputOpts[i]))<br>
TranslatedArgs->eraseArg(OutputOpts[i]);<br>
}<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br>
</blockquote></div><br></body></html>