<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On May 2, 2012, at 1:19 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Wed, May 2, 2012 at 7:34 AM, Douglas Gregor <span dir="ltr"><<a href="mailto:dgregor@apple.com" target="_blank">dgregor@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: dgregor<br>
Date: Wed May 2 09:34:16 2012<br>
New Revision: 155988<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=155988&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=155988&view=rev</a><br>
Log:<br>
Replace a ConsumeAnyToken() call with ConsumeToken() when we know<br>
we're looking at a normal token. Tiny positive impact -fsyntax-only<br>
time for <<a href="rdar://problem/11004361">rdar://problem/11004361</a>>.<br></blockquote><div><br></div><div>If we no longer intend to ensure ConsumeCodeCompletionToken() is called to consume a code_completion token, is there any value in keeping it around as a separate function?</div></div></blockquote><div><br></div>ConsumeCodeCompletionToken() consumes the token without invoking the "unexpected" code-completion logic, which is rather important.</div><div><br></div><div><blockquote type="cite"><div class="gmail_quote"><div>(I also wonder why we have a separate ConsumeStringToken function, given that it does nothing special since translation phase 6 is performed manually within the parser…)</div></div></blockquote><div><br></div><div>That, I don't know.</div><div><br></div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div><div><br><blockquote type="cite"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Modified:<br>
cfe/trunk/lib/Parse/Parser.cpp<br>
<br>
Modified: cfe/trunk/lib/Parse/Parser.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/Parser.cpp?rev=155988&r1=155987&r2=155988&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/Parser.cpp?rev=155988&r1=155987&r2=155988&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Parse/Parser.cpp (original)<br>
+++ cfe/trunk/lib/Parse/Parser.cpp Wed May 2 09:34:16 2012<br>
@@ -185,7 +185,7 @@<br>
<br>
bool Parser::ExpectAndConsumeSemi(unsigned DiagID) {<br>
if (<a href="http://Tok.is">Tok.is</a>(tok::semi) || <a href="http://Tok.is">Tok.is</a>(tok::code_completion)) {<br>
- ConsumeAnyToken();<br>
+ ConsumeToken();<br>
return false;<br>
}<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br>
</blockquote></div><br></body></html>