<div class="gmail_extra"><div class="gmail_quote">On Tue, May 1, 2012 at 4:51 PM, Andrew Trick <span dir="ltr"><<a href="mailto:atrick@apple.com" target="_blank">atrick@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On May 1, 2012, at 2:58 PM, Richard Smith <<a href="mailto:richard-llvm@metafoo.co.uk">richard-llvm@metafoo.co.uk</a>> wrote:<br>
<br>
> Author: rsmith<br>
> Date: Tue May  1 16:58:31 2012<br>
> New Revision: 155951<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=155951&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=155951&view=rev</a><br>
> Log:<br>
> Fix RecursiveASTVisitor's data recursion to call the Traverse* functions if they<br>
> have been overridden in the derived class. Also, remove a non-functional<br>
> implementation of an incorrect optimization for ParenExprs.<br>
><br>
> Modified:<br>
>    cfe/trunk/include/clang/AST/RecursiveASTVisitor.h<br>
>    cfe/trunk/unittests/Tooling/RecursiveASTVisitorTest.cpp<br>
><br>
> Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/RecursiveASTVisitor.h?rev=155951&r1=155950&r2=155951&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/RecursiveASTVisitor.h?rev=155951&r1=155950&r2=155951&view=diff</a><br>

> ==============================================================================<br>
<br>
</div>Richard,<br>
<br>
I had to revert this because the following test failure was blocking other tests. Let me know if you need more details in order to fix it.<br></blockquote><div><br></div><div>I see why this test was failing: libclang's BodyIndexer overrides TraverseCXXOperatorCallExpr. So the original change which introduced this test had actually broken part of libclang, which this patch fixed. Do you have any objection to me reinstating my change and disabling this test?</div>
</div></div>